You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/01/07 20:50:29 UTC
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/609
[Zeppelin 546](documentation) Enables interpreter library loading from maven repository
### What is this PR for?
This PR is related to #590. This documentation may explain the overall process of **Dynamic Interpreter Loading** in [Helium Proposal](https://issues.apache.org/jira/browse/ZEPPELIN-533).
Moreover, at the last this documentation, Zeppelin users can get the basic information about step by step of interpreter setting & configuring & binding. Since I assumed that they are novice at Zeppelin.
### What type of PR is it?
Documentation
### Todos
* [x] - Add docs image under `/docs/assets/themes/zeppelin/img/docs-img/`
* [x] - Add dynamicinterpreter.md
* [x] - Add dynamicinterpreter.html location to `docs/_includes/themes/zeppelin/_navigation.html`
### Is there a relevant Jira issue?
1. [ZEPPELIN-533 Helium](https://issues.apache.org/jira/browse/ZEPPELIN-533)
2. [ZEPPELIN-546](https://issues.apache.org/jira/browse/ZEPPELIN-546)
### How should this be tested?
### Screenshots (if appropriate)
Hopefully, below image helps you to understand this process : )
### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-546-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/609.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #609
----
commit 3067025a65e830ccf2f924c0c148e41c311646db
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-07T19:24:48Z
ZEPPELIN-546-docs: Add docs image
commit 16b46f455721a782f4c75e7c57af13571f85d091
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-07T19:27:36Z
ZEPPELIN-546-docs: Add dynamicinterpreterload.md
commit a9ec7d7c67e507a90169b783bf1dcbdc02ad1bbe
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-07T19:29:36Z
ZEPPELIN-546-docs: Add dynamicinterpreterload.html location to _navigation.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/609#issuecomment-171200014
Thanks, We can merge it when the other PR is merges :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/609#issuecomment-171179305
@corneadoug Thank you for your prudent review. I applied all of your comment in this docs : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/609#issuecomment-171852616
Merging if theres no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/609#issuecomment-172395625
@AhyoungRyu Could you rebase your branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/609
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/609#issuecomment-172403544
@felixcheung haha thanks, I mistook the CI error for the conflicts one :) (especially since I saw other github notifications about documentation asking for rebase)
Since some of the profile are green and its documentation, I'm merging it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/609#issuecomment-172399870
@corneadoug it says no conflicts with the base?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/609#issuecomment-169856290
@felixcheung
Thank you for the review : )
I fixed them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 546](documentation) Ena...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/609#issuecomment-170413585
looks good, nice graphic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---