You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2015/04/02 23:24:47 UTC
[1/4] hbase git commit: HBASE-13388 Handling NullPointer in
ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)
Repository: hbase
Updated Branches:
refs/heads/0.98 27ec6bc88 -> 2ec3443f0
refs/heads/branch-1 3c0e3981a -> 6605dda7b
refs/heads/branch-1.0 86cbd1b5d -> 374a29405
refs/heads/master 578df6dfc -> 2365932d7
HBASE-13388 Handling NullPointer in ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/2365932d
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/2365932d
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/2365932d
Branch: refs/heads/master
Commit: 2365932d78180255be7145d8d247ee1f801aed1d
Parents: 578df6d
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Apr 2 14:17:26 2015 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Apr 2 14:17:26 2015 -0700
----------------------------------------------------------------------
.../org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/2365932d/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
index a13292e..387c2e4 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
@@ -200,7 +200,6 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
Subprocedure subproc = null;
try {
byte[] data = ZKUtil.getData(zkController.getWatcher(), path);
- LOG.debug("start proc data length is " + data.length);
if (!ProtobufUtil.isPBMagicPrefix(data)) {
String msg = "Data in for starting procuedure " + opName +
" is illegally formatted (no pb magic). " +
@@ -208,6 +207,7 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
LOG.error(msg);
throw new IllegalArgumentException(msg);
}
+ LOG.debug("start proc data length is " + data.length);
data = Arrays.copyOfRange(data, ProtobufUtil.lengthOfPBMagic(), data.length);
LOG.debug("Found data for znode:" + path);
subproc = member.createSubprocedure(opName, data);
[4/4] hbase git commit: HBASE-13388 Handling NullPointer in
ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)
Posted by ap...@apache.org.
HBASE-13388 Handling NullPointer in ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/2ec3443f
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/2ec3443f
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/2ec3443f
Branch: refs/heads/0.98
Commit: 2ec3443f07c022516b538596a41dc7f6f78d26d1
Parents: 27ec6bc
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Apr 2 14:17:26 2015 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Apr 2 14:18:15 2015 -0700
----------------------------------------------------------------------
.../org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/2ec3443f/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
index 9918d11..dd26328 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
@@ -200,7 +200,6 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
Subprocedure subproc = null;
try {
byte[] data = ZKUtil.getData(zkController.getWatcher(), path);
- LOG.debug("start proc data length is " + data.length);
if (!ProtobufUtil.isPBMagicPrefix(data)) {
String msg = "Data in for starting procuedure " + opName +
" is illegally formatted (no pb magic). " +
@@ -208,6 +207,7 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
LOG.error(msg);
throw new IllegalArgumentException(msg);
}
+ LOG.debug("start proc data length is " + data.length);
data = Arrays.copyOfRange(data, ProtobufUtil.lengthOfPBMagic(), data.length);
LOG.debug("Found data for znode:" + path);
subproc = member.createSubprocedure(opName, data);
[2/4] hbase git commit: HBASE-13388 Handling NullPointer in
ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)
Posted by ap...@apache.org.
HBASE-13388 Handling NullPointer in ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/6605dda7
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/6605dda7
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/6605dda7
Branch: refs/heads/branch-1
Commit: 6605dda7b40a7dab8cf6a2188ed5086dd3d39def
Parents: 3c0e398
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Apr 2 14:17:26 2015 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Apr 2 14:18:07 2015 -0700
----------------------------------------------------------------------
.../org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/6605dda7/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
index a13292e..387c2e4 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
@@ -200,7 +200,6 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
Subprocedure subproc = null;
try {
byte[] data = ZKUtil.getData(zkController.getWatcher(), path);
- LOG.debug("start proc data length is " + data.length);
if (!ProtobufUtil.isPBMagicPrefix(data)) {
String msg = "Data in for starting procuedure " + opName +
" is illegally formatted (no pb magic). " +
@@ -208,6 +207,7 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
LOG.error(msg);
throw new IllegalArgumentException(msg);
}
+ LOG.debug("start proc data length is " + data.length);
data = Arrays.copyOfRange(data, ProtobufUtil.lengthOfPBMagic(), data.length);
LOG.debug("Found data for znode:" + path);
subproc = member.createSubprocedure(opName, data);
[3/4] hbase git commit: HBASE-13388 Handling NullPointer in
ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)
Posted by ap...@apache.org.
HBASE-13388 Handling NullPointer in ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/374a2940
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/374a2940
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/374a2940
Branch: refs/heads/branch-1.0
Commit: 374a29405a4e9b5b980d824f56db654c002e1e40
Parents: 86cbd1b
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Apr 2 14:17:26 2015 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Apr 2 14:18:11 2015 -0700
----------------------------------------------------------------------
.../org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/374a2940/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
index a13292e..387c2e4 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
@@ -200,7 +200,6 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
Subprocedure subproc = null;
try {
byte[] data = ZKUtil.getData(zkController.getWatcher(), path);
- LOG.debug("start proc data length is " + data.length);
if (!ProtobufUtil.isPBMagicPrefix(data)) {
String msg = "Data in for starting procuedure " + opName +
" is illegally formatted (no pb magic). " +
@@ -208,6 +207,7 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
LOG.error(msg);
throw new IllegalArgumentException(msg);
}
+ LOG.debug("start proc data length is " + data.length);
data = Arrays.copyOfRange(data, ProtobufUtil.lengthOfPBMagic(), data.length);
LOG.debug("Found data for znode:" + path);
subproc = member.createSubprocedure(opName, data);