[jira] [Work logged] (BEAM-12305) Add pack_combiners to FlinkRunner and SparkRunner

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-12305?focusedWorklogId=600544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600544 ]

ASF GitHub Bot logged work on BEAM-12305:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/May/21 17:47
            Start Date: 21/May/21 17:47
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on a change in pull request #14842:
URL: https://github.com/apache/beam/pull/14842#discussion_r637098884



##########
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##########
@@ -426,6 +422,12 @@ def test_expand_kafka_write(self):
   def test_sql(self):
     raise unittest.SkipTest("BEAM-7252")
 
+  def test_pack_combiners(self):
+    raise unittest.SkipTest(

Review comment:
       Lets add an optional flag to test_pack_combiners of whether to verify this happened via counters. We can override this here to pass the non-default value of the flag so we can still run the test (and ensure the outputs are correct) despite the issue with using counters to verify the packing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 600544)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add pack_combiners to FlinkRunner and SparkRunner
> -------------------------------------------------
>
>                 Key: BEAM-12305
>                 URL: https://issues.apache.org/jira/browse/BEAM-12305
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Yifan Mai
>            Priority: P2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the pack_combiners unit test is failing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)