You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "tuxji (via GitHub)" <gi...@apache.org> on 2023/02/21 23:23:01 UTC
[GitHub] [daffodil-site] tuxji opened a new pull request, #106: Rename daffodil-runtime2
tuxji opened a new pull request, #106:
URL: https://github.com/apache/daffodil-site/pull/106
Make sure all places mentioning runtime2 are updated as part of renaming daffodil-runtime2 to daffodil-codegen-c.
2.6.0.md, 3.1.0.md, 3.2.0.md, 3.2.1.md, 3.3.0.md, 3.4.0.md: Rename runtime2 to codegen-c. Update link to daffodilc-todos.
cli.md: Rename runtime2 to codegen-c.
daffodilc-todos.adoc: Rename from runtime2-todos.adoc. Rename runtime2 to codegen-c.
DAFFODIL-2796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] mbeckerle commented on a diff in pull request #106: Rename daffodil-runtime2
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on code in PR #106:
URL: https://github.com/apache/daffodil-site/pull/106#discussion_r1114360112
##########
site/_releases/2.6.0.md:
##########
@@ -78,7 +78,7 @@ Improvements were made to the TDML runner.
* {% jira 2283 %} ATO and HL7 saved parsers fail with Stack Overflow errors during generation on commit 7e8e1b3e
* {% jira 2284 %} Non-thread safe failures with JSON schema
* {% jira 2290 %} Change download links to downloads.apache.org
-* {% jira 2288 %} update jackson-core dependency to 2.9.8 to facility runtime2 work
+* {% jira 2288 %} update jackson-core dependency to 2.9.8 to facility codegen-c work
Review Comment:
For all these pre-existing releases, shouldn't this say "codegen-c (aka runtime2)", with only the forthcoming releases fully dropping the runtime2 qualifier?
##########
site/_releases/3.1.0.md:
##########
@@ -21,19 +21,20 @@ binary-dist:
scala-version: 2.12
---
-#### Code Generation Backend (runtime2)
+#### Code Generation Backend (codegen-c)
-A new code generation back-end, called `runtime2`, is added supporting generating
-C code with limited parse and unparse capabilities. See the [Command Line
-Interface](/cli) page for commands and options to generate code. Visit
-[Runtime2 ToDos](/dev/design-notes/runtime2-todos/) for a list of limitations
+A new code generation backend, called `daffodil-codegen-c`, is added
Review Comment:
Yeah, here, in version 3.1.0, it isn't actually called this. It's called runtime2 here.
I think it's good to suggest it be referred to as the codegen-c, but the actual code identifier of the module is still daffodil-runtime2 in this.
##########
site/dev/design-notes/daffodilc-todos.adoc:
##########
@@ -297,7 +297,7 @@ like an offline log processor does.
=== Recovering after errors
-As we continue to build out runtime2,
+As we continue to build out codegen-c,
Review Comment:
Here I have no issues. Renaming it fully here is good.
It's only in the documents that specifically describe older, non-changing releases that I have misgivings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] tuxji commented on a diff in pull request #106: Rename daffodil-runtime2
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on code in PR #106:
URL: https://github.com/apache/daffodil-site/pull/106#discussion_r1114520589
##########
site/cli.md:
##########
@@ -55,7 +55,7 @@ Setting environment variables may be necessary to allow imports, includes, and r
``CC``
- : If you need to specify which C compiler should be called when running TDML files with the ``test`` subcommand using Daffodil's runtime2 backend, you can set the ``CC`` environment variable. If that environment variable is not specified, then Daffodil will call the first C compiler driver command it finds within the ``PATH`` environment variable from the following list: "zig cc", "cc", "clang", "gcc" (in that order). The reason for "zig cc" coming first is because [zig cc](https://andrewkelley.me/post/zig-cc-powerful-drop-in-replacement-gcc-clang.html) uses a sophisticated caching system to avoid recompiling the same C source files, which can speed up TDML tests.
+ : If you need to specify which C compiler should be called when running TDML files with the ``test`` subcommand using Daffodil's codegen-c backend, you can set the ``CC`` environment variable. If that environment variable is not specified, then Daffodil will call the first C compiler driver command it finds within the ``PATH`` environment variable from the following list: "zig cc", "cc", "clang", "gcc" (in that order). The reason for "zig cc" coming first is because [zig cc](https://andrewkelley.me/post/zig-cc-powerful-drop-in-replacement-gcc-clang.html) uses a sophisticated caching system to avoid recompiling the same C source files, which can speed up TDML tests.
Review Comment:
By the way, why does cli.md have very long lines? What would happen if we wrapped these lines to 72 or 80 columns instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] tuxji commented on a diff in pull request #106: Rename daffodil-runtime2
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on code in PR #106:
URL: https://github.com/apache/daffodil-site/pull/106#discussion_r1114508543
##########
site/_releases/3.1.0.md:
##########
@@ -21,19 +21,20 @@ binary-dist:
scala-version: 2.12
---
-#### Code Generation Backend (runtime2)
+#### Code Generation Backend (codegen-c)
-A new code generation back-end, called `runtime2`, is added supporting generating
-C code with limited parse and unparse capabilities. See the [Command Line
-Interface](/cli) page for commands and options to generate code. Visit
-[Runtime2 ToDos](/dev/design-notes/runtime2-todos/) for a list of limitations
+A new code generation backend, called `daffodil-codegen-c`, is added
Review Comment:
Sure, I'll update the old releases notes to keep runtime2 and send another commit for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] tuxji merged pull request #106: Rename daffodil-runtime2
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji merged PR #106:
URL: https://github.com/apache/daffodil-site/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org