You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2021/01/31 23:14:55 UTC
[GitHub] [openmeetings] sebawagner opened a new pull request #124: OPENMEETINGS-2565 Spelling mistake in web service method
sebawagner opened a new pull request #124:
URL: https://github.com/apache/openmeetings/pull/124
See Jira for details
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax merged pull request #124: OPENMEETINGS-2565 Spelling mistake in web service method
Posted by GitBox <gi...@apache.org>.
solomax merged pull request #124:
URL: https://github.com/apache/openmeetings/pull/124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a change in pull request #124: OPENMEETINGS-2565 Spelling mistake in web service method
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #124:
URL: https://github.com/apache/openmeetings/pull/124#discussion_r567730958
##########
File path: openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/RoomWebService.java
##########
@@ -164,7 +164,7 @@ private Room updateRtoRoom(Room r, Long userId) {
*/
@WebMethod
@GET
- @Path("/{type}/{externaltype}/{externaliid}")
+ @Path("/{type}/{externaltype}/{externalid}")
Review comment:
@sebawagner good catch!
can you add JUnit test for this method? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org