You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/03/07 05:59:11 UTC
[kyuubi] branch branch-1.7 updated: [KYUUBI #4462] Fix variable usage issue in `SessionManager#stop`
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/branch-1.7 by this push:
new 0ac50053c [KYUUBI #4462] Fix variable usage issue in `SessionManager#stop`
0ac50053c is described below
commit 0ac50053cf339d09a77b789182bf28ab179f170d
Author: Yikf <yi...@apache.org>
AuthorDate: Tue Mar 7 13:58:43 2023 +0800
[KYUUBI #4462] Fix variable usage issue in `SessionManager#stop`
### _Why are the changes needed?_
Fix variable usage issue in `SessionManager#stop`
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #4462 from Yikf/sessionmanager.
Closes #4462
d4340d4ec [Yikf] fix variable usage issue
Authored-by: Yikf <yi...@apache.org>
Signed-off-by: Cheng Pan <ch...@apache.org>
(cherry picked from commit 8af07fa47d7fca926a97267fe95b52b4eba42ea5)
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.../src/main/scala/org/apache/kyuubi/session/SessionManager.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
index 662ac3e58..cc5b6b39c 100644
--- a/kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
+++ b/kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
@@ -283,9 +283,9 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
shutdown = true
val shutdownTimeout: Long =
if (isServer) {
- conf.get(ENGINE_EXEC_POOL_SHUTDOWN_TIMEOUT)
- } else {
conf.get(SERVER_EXEC_POOL_SHUTDOWN_TIMEOUT)
+ } else {
+ conf.get(ENGINE_EXEC_POOL_SHUTDOWN_TIMEOUT)
}
ThreadUtils.shutdown(timeoutChecker, Duration(shutdownTimeout, TimeUnit.MILLISECONDS))