[GitHub] [apisix] agile6v commented on a change in pull request #5286: fix: unable to read response body when proxied server returned chunked response

[GitBox <gi...@apache.org>]

agile6v commented on a change in pull request #5286:
URL: https://github.com/apache/apisix/pull/5286#discussion_r731794429



##########
File path: apisix/core/response.lua
##########
@@ -170,11 +170,13 @@ function _M.hold_body_chunk(ctx)
     if eof then
         body_buffer = ctx._body_buffer
         if not body_buffer then
-            return chunk
+            body_buffer = chunk
+        else
+            body_buffer = concat_tab(body_buffer, "", 1, body_buffer.n)
+            ctx._body_buffer = nil
         end
 
-        body_buffer = concat_tab(body_buffer, "", 1, body_buffer.n)
-        ctx._body_buffer = nil
+        arg[1] = body_buffer

Review comment:
       Oops! I missed the comments.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org