You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/07/14 21:19:14 UTC
[jira] Created: (WINK-95) HttpMethod annotation behaivor
HttpMethod annotation behaivor
------------------------------
Key: WINK-95
URL: https://issues.apache.org/jira/browse/WINK-95
Project: Wink
Issue Type: Bug
Components: Common
Affects Versions: 0.1
Reporter: Bryant Luk
Priority: Minor
In the JavaDoc for @HttpMethod, it says:
"It is an error for a method to be annotated with more than one annotation that is annotated with HttpMethod."
I think we should at least issue a warning if we don't outright fail here. I imagine that a user will try to put @POST and @PUT methods on a method. I think the design restriction was to force users to think heavily and not abuse the HTTP Methods.
Also, I think in ResourceMetadataCollector.getHttpMethod(Method method) :
{code}
HttpMethod httpMethod = method.getAnnotation(HttpMethod.class);
if (httpMethod != null) {
return httpMethod;
}
{code}
The above is not necessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WINK-95) HttpMethod annotation behaivor
Posted by "Nadav Fischer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nadav Fischer reassigned WINK-95:
---------------------------------
Assignee: Nadav Fischer
> HttpMethod annotation behaivor
> ------------------------------
>
> Key: WINK-95
> URL: https://issues.apache.org/jira/browse/WINK-95
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Nadav Fischer
> Priority: Minor
>
> In the JavaDoc for @HttpMethod, it says:
> "It is an error for a method to be annotated with more than one annotation that is annotated with HttpMethod."
> I think we should at least issue a warning if we don't outright fail here. I imagine that a user will try to put @POST and @PUT methods on a method. I think the design restriction was to force users to think heavily and not abuse the HTTP Methods.
> Also, I think in ResourceMetadataCollector.getHttpMethod(Method method) :
> {code}
> HttpMethod httpMethod = method.getAnnotation(HttpMethod.class);
> if (httpMethod != null) {
> return httpMethod;
> }
> {code}
> The above is not necessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-95) HttpMethod annotation behaivor
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731489#action_12731489 ]
Hudson commented on WINK-95:
----------------------------
Integrated in Wink-Trunk-JDK1.5 #11 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/11/])
> HttpMethod annotation behaivor
> ------------------------------
>
> Key: WINK-95
> URL: https://issues.apache.org/jira/browse/WINK-95
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Nadav Fischer
> Priority: Minor
> Fix For: 0.1
>
>
> In the JavaDoc for @HttpMethod, it says:
> "It is an error for a method to be annotated with more than one annotation that is annotated with HttpMethod."
> I think we should at least issue a warning if we don't outright fail here. I imagine that a user will try to put @POST and @PUT methods on a method. I think the design restriction was to force users to think heavily and not abuse the HTTP Methods.
> Also, I think in ResourceMetadataCollector.getHttpMethod(Method method) :
> {code}
> HttpMethod httpMethod = method.getAnnotation(HttpMethod.class);
> if (httpMethod != null) {
> return httpMethod;
> }
> {code}
> The above is not necessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-95) HttpMethod annotation behaivor
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk closed WINK-95.
--------------------------
Thanks Nadav.
> HttpMethod annotation behaivor
> ------------------------------
>
> Key: WINK-95
> URL: https://issues.apache.org/jira/browse/WINK-95
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Nadav Fischer
> Priority: Minor
> Fix For: 0.1
>
>
> In the JavaDoc for @HttpMethod, it says:
> "It is an error for a method to be annotated with more than one annotation that is annotated with HttpMethod."
> I think we should at least issue a warning if we don't outright fail here. I imagine that a user will try to put @POST and @PUT methods on a method. I think the design restriction was to force users to think heavily and not abuse the HTTP Methods.
> Also, I think in ResourceMetadataCollector.getHttpMethod(Method method) :
> {code}
> HttpMethod httpMethod = method.getAnnotation(HttpMethod.class);
> if (httpMethod != null) {
> return httpMethod;
> }
> {code}
> The above is not necessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-95) HttpMethod annotation behaivor
Posted by "Nadav Fischer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nadav Fischer resolved WINK-95.
-------------------------------
Resolution: Fixed
Fix Version/s: 0.1
> HttpMethod annotation behaivor
> ------------------------------
>
> Key: WINK-95
> URL: https://issues.apache.org/jira/browse/WINK-95
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Nadav Fischer
> Priority: Minor
> Fix For: 0.1
>
>
> In the JavaDoc for @HttpMethod, it says:
> "It is an error for a method to be annotated with more than one annotation that is annotated with HttpMethod."
> I think we should at least issue a warning if we don't outright fail here. I imagine that a user will try to put @POST and @PUT methods on a method. I think the design restriction was to force users to think heavily and not abuse the HTTP Methods.
> Also, I think in ResourceMetadataCollector.getHttpMethod(Method method) :
> {code}
> HttpMethod httpMethod = method.getAnnotation(HttpMethod.class);
> if (httpMethod != null) {
> return httpMethod;
> }
> {code}
> The above is not necessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.