You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/10 09:48:26 UTC
[GitHub] [apisix] gy09535 opened a new issue #2693: feat: Should we add metric for logger sender and zipkin ?
gy09535 opened a new issue #2693:
URL: https://github.com/apache/apisix/issues/2693
### Issue description
Now the log sender batch store the data in memory , we can not know how many logs or spans is send, so I think we can add some metric to monitor it.
### Environment
* apisix version (cmd: `apisix version`):
* OS:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #2693: [DISCUSS] Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-725935297
> We can add plugin init method to register their own metric,And provide api to change it value.
@gy09535
Pull request is welcome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on issue #2693: feat: Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 edited a comment on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-724643821
> I think we need to allow plugin to register their metrics. Like a `_M.collect` method and prometheus will call them when in need.
We can add plugin init method to register their own metric,And provide api to change it value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #2693: [DISCUSS] Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #2693:
URL: https://github.com/apache/apisix/issues/2693
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2693: feat: Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-724591252
I do it in my private repository should apisix need it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2693: feat: Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-724641906
> Could you provide a design about it?
When prometheus exporter init , I add a gauge to metric with label : node，route_id, type。And I export two module function inc and set to change the gauge value. In "syslog plugin" log method I use this module method inc it value, and in batch process I reduce it value. And zipkin is also do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2693: [DISCUSS] Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-726119706
> > We can add plugin init method to register their own metric,And provide api to change it value.
>
> @gy09535
> Pull request is welcome!
Please assign to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #2693: feat: Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-724601583
Could you provide a design about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on issue #2693: feat: Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 edited a comment on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-724641906
> Could you provide a design about it?
When prometheus exporter init , I add a gauge to metric with label : node，route_id, type。And I export two module function inc and set to change the gauge value. In "syslog-plugin" log method, I use this module method inc it value, and in batch process I reduce it value. And zipkin is also do that.
This can help us know how many remaining spans and logs per route can not send.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2693: feat: Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-724643821
> I think we need to allow plugin to register their metrics. Like a `_M.collect` method and prometheus will call them when in need.
We can add plugin init method to register their own metric
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #2693: feat: Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-724640853
I think we need to allow plugin to register their metrics. Like a `_M.collect` method and prometheus will call them when in need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on issue #2693: feat: Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 edited a comment on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-724641906
> Could you provide a design about it?
When prometheus exporter init , I add a gauge to metric with label : node，route_id, type。And I export two module function inc and set to change the gauge value. In "syslog plugin" log method I use this module method inc it value, and in batch process I reduce it value. And zipkin is also do that.
This can help us know how many remaining spans and logs per route can not send.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2693: [DISCUSS] Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-725936097
haha , I will do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 removed a comment on issue #2693: [DISCUSS] Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 removed a comment on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-725936097
haha , I will do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2693: [DISCUSS] Should we add metric for log sender and zipkin ?
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2693:
URL: https://github.com/apache/apisix/issues/2693#issuecomment-725936317
> > We can add plugin init method to register their own metric,And provide api to change it value.
>
> @gy09535
> Pull request is welcome!
haha, I wil do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org