You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/06/18 20:34:00 UTC

[GitHub] [zookeeper] tudor opened a new pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

tudor opened a new pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385


   See https://issues.apache.org/jira/browse/ZOOKEEPER-3868


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tudor commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
tudor commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-658399019


   @eolivelli @ztzg @symat ping? :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-665601511


   Hi @tudor,
   
   I’ve had a look at this; it's a nasty thing.
   
   `DeliverWatchersWrapper` in `tests/ZKMocks.cc` tries to stop (some) threads by forcefully setting `zh->close_requested=1` via `terminateZookeeperThreads`. `adaptor_finish` is not called when it does that, which means that `terminate_completion` remains "false."  `do_completion` consequently does not exit as it expects.
   
   (I haven't investigated further.)
   
   HTH, -D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-661039208


   maybe the unit test failure is unrelated... I try to re-trigger the jenkins job.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-661059729


   I see the same failure after the new unit test execution: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/2147/console
   
   `ZKMocks.cc:288: SyncedBoolCondition DeliverWatchersWrapper::isDelivered() const: Assertion 'i<1000' failed.` for `Zookeeper_watchers::testDefaultSessionWatcher1` 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-661032957


   @tudor there is a failed unit test reported by the maven job: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/2140/console
   
   please take a look if you can, it seems to be related (`Zookeeper_watchers::testDefaultSessionWatcher1`). 
   
   I also copy the output in case the jenkins logs would be cleaned later:
   
   ```
   ....
        [exec] Zookeeper_multi::testWatch : elapsed 2010 : OK
        [exec] Zookeeper_multi::testSequentialNodeCreateInAsyncMulti : elapsed 2003 : OK
        [exec] Zookeeper_multi::testBigAsyncMulti : elapsed 3005 : OK
        [exec] Zookeeper_watchers::testDefaultSessionWatcher1FAIL: zktest-mt
        [exec] ==========================================
        [exec] 1 of 2 tests failed
        [exec] Please report to user@zookeeper.apache.org
        [exec] ==========================================
        [exec] Makefile:1850: recipe for target 'check-TESTS' failed
        [exec] make[1]: Leaving directory '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-client/zookeeper-client-c/target/c'
        [exec] Makefile:2106: recipe for target 'check-am' failed
        [exec] zktest-mt: /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-client/zookeeper-client-c/tests/ZKMocks.cc:288: SyncedBoolCondition DeliverWatchersWrapper::isDelivered() const: Assertion `i<1000' failed.
        [exec] /bin/bash: line 5:  8399 Aborted                 ZKROOT=/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-client/zookeeper-client-c/../.. CLASSPATH=$CLASSPATH:$CLOVER_HOME/lib/clover*.jar ${dir}$tst
        [exec] make[1]: *** [check-TESTS] Error 1
        [exec] make: *** [check-am] Error 2
   ....
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-665463326


   Hi @tudor, @symat,
   
   Sorry for the delay; I've been a bit "disconnected" and almost missed this. I'll have a look ASAP.
   
   Cheers, -D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-658550270


   Did you consider adding a test case?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tudor commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
tudor commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-646373339


   The s390x build failed with "An error occurred while generating the build script." which I'm pretty sure is unrelated to my change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tudor commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
tudor commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-661313033


   That's weird, I'll investigate.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-661034390


   > The s390x build failed with "An error occurred while generating the build script." which I'm pretty sure is unrelated to my change.
   
   Yes, that travis job failure is strange... I haven't seen it yet. but if it happens again, we may need to debug it :)
   
   (the unit test failure was reported by the jenkinsMaven job, and not by the travis job)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1385: ZOOKEEPER-3868: Completion leak in zookeeper_close

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1385:
URL: https://github.com/apache/zookeeper/pull/1385#issuecomment-661039355


   retest maven build


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org