You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/24 13:28:17 UTC

[GitHub] [flink] becketqin opened a new pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

becketqin opened a new pull request #12766:
URL: https://github.com/apache/flink/pull/12766


   ## What is the purpose of the change
   Rename `StreamExecutionEnvironment#continuousSource()` to `StreamExecutionEnvironment#source()` according to the original FLIP-27 design.
   
   ## Brief change log
   Rename `StreamExecutionEnvironment#continuousSource()` to `StreamExecutionEnvironment#source()`
   
   ## Verifying this change
   This is a method rename.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs / JavaDocs)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648871161


   +1 from my side
   
   Personally I am fine with either `fromSource`/`addSource`/`source`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] asfgit closed pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #12766:
URL: https://github.com/apache/flink/pull/12766


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648860657


   Why don't we call this method `fromSource`? We have `fromElements`, `fromCollection`, `fromParallelCollection`. It is confusing that we also have `addSource`, `readFile`, and `createInput`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648821613


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 71eefff46a38b7b50afb251e5fb338f64134a821 (Wed Jun 24 13:31:10 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
twalthr edited a comment on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648860657


   Why don't we call this method `fromSource`? We have `fromElements`, `fromCollection`, `fromParallelCollection`. It is confusing that we also have `addSource`, `readFile`, and `createInput`. Now we add another flavor that is just called `source`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] becketqin commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648897424


   @twalthr @dawidwys Thanks for the review. I'll merge the patch after the CI tests pass.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4010",
       "triggerID" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f02e6446e1c33e34a613d06ff2af4098d7ec08f7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4015",
       "triggerID" : "f02e6446e1c33e34a613d06ff2af4098d7ec08f7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71eefff46a38b7b50afb251e5fb338f64134a821 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4010) 
   * f02e6446e1c33e34a613d06ff2af4098d7ec08f7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4015) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71eefff46a38b7b50afb251e5fb338f64134a821 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648925287


   +1 from my side


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4010",
       "triggerID" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71eefff46a38b7b50afb251e5fb338f64134a821 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4010) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4010",
       "triggerID" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f02e6446e1c33e34a613d06ff2af4098d7ec08f7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f02e6446e1c33e34a613d06ff2af4098d7ec08f7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71eefff46a38b7b50afb251e5fb338f64134a821 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4010) 
   * f02e6446e1c33e34a613d06ff2af4098d7ec08f7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] becketqin commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648890887


   @twalthr I think the clearest naming is either `StreamExecutionEnvironment#dataStreamFromSource()` or `DataStream#fromSource()`. But given the current status, I agree that `StreamExecutionEnvironment#fromSource()` is better than just `source()`. At least this would give a consistent style after we deprecate `readFile()`, `addSource()` and `createInput()`. I'll update the patch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648947003


   Merging this as part of the current batch of fixes...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12766:
URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4010",
       "triggerID" : "71eefff46a38b7b50afb251e5fb338f64134a821",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f02e6446e1c33e34a613d06ff2af4098d7ec08f7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4015",
       "triggerID" : "f02e6446e1c33e34a613d06ff2af4098d7ec08f7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71eefff46a38b7b50afb251e5fb338f64134a821 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4010) 
   * f02e6446e1c33e34a613d06ff2af4098d7ec08f7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4015) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org