You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/15 01:26:34 UTC

[GitHub] [apisix-dashboard] Baoyuantop commented on a diff in pull request #2506: feat(plugin): global plugin list in order by state (#2299)

Baoyuantop commented on code in PR #2506:
URL: https://github.com/apache/apisix-dashboard/pull/2506#discussion_r921730490


##########
web/src/components/Plugin/PluginPage.tsx:
##########
@@ -87,6 +86,10 @@ const PluginPage: React.FC<Props> = ({
       });
       setTypeList(categoryList);
     });
+  }, [initialData, referPage]);
+
+  useEffect(() => {
+    setPlugins(initialData);

Review Comment:
   Why not just use initialData as the initial value of plugins state?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org