[jira] [Comment Edited] (PHOENIX-5607) Client-server backward compatibility tests

["Chinmay Kulkarni (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056129#comment-17056129 ] 

Chinmay Kulkarni edited comment on PHOENIX-5607 at 3/10/20, 4:53 PM:
---------------------------------------------------------------------

[~stoty]thanks for bringing that to my attention! It was an oversight. I will commit to the 4.x branch as well.

BTW [~sandeep.guggilam], I realized that we hardcode the compatible clients versions to <"4.14.3-HBase-1.3", "4.15.0-HBase-1.3">. For HBase-1.4 and 1.5 branches, this should be changed right?

This may now actually have become easier with unified 4.x branches since we basically just need to extract the hbase version from the build profile, is this assumption correct [~stoty]? 

Also, [~stoty] this means that the 4.x-HBase-1.* branches will essentially no longer be used for any releases henceforth, correct?



was (Author: ckulkarni):
[~stoty]thanks for bringing that to my attention! It was an oversight. I will commit to the 4.x branch as well.

BTW [~sandeep.guggilam], I realized that we hardcode the compatible clients versions to <"4.14.3-HBase-1.3", "4.15.0-HBase-1.3">. For HBase-1.4 and 1.5 branches, this should be changed right?

This may now actually have become easier with unified 4.x branches since we basically just need to extract the hbase version from the build profile. Also, [~stoty] this means that the 4.x-HBase-1.* branches will essentially no longer be used for any releases henceforth, correct?

> Client-server backward compatibility tests 
> -------------------------------------------
>
>                 Key: PHOENIX-5607
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5607
>             Project: Phoenix
>          Issue Type: Test
>    Affects Versions: 4.15.0
>            Reporter: Lars Hofhansl
>            Assignee: Sandeep Guggilam
>            Priority: Blocker
>              Labels: phoenix-hardening
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-5607.4.x-HBase-1.3.v1.patch, PHOENIX-5607.4.x-HBase-1.3.v2.patch, PHOENIX-5607.4.x-HBase-1.3.v3.patch, PHOENIX-5607.4.x-HBase-1.3.v4.patch, PHOENIX-5607.4.x-HBase-1.3.v5.patch, PHOENIX-5607.master.v1.patch
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Filing this as a blocker for 4.16.0.
> As we've seen with the various failed attempts to release 4.15.0 Phoenix' backwards compatibility story is weak, and lacks tests - in fact there're no tests.
> We should not allow to ship 4.16.0 without improving that and without tests.
> [~ckulkarni], [~gjacoby] , FYI, what we discussed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)