You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/10/02 14:18:47 UTC

[GitHub] [maven-integration-testing] khmarbaise commented on pull request #113: MNG-7232 - Make final variable when is possible.

khmarbaise commented on pull request #113:
URL: https://github.com/apache/maven-integration-testing/pull/113#issuecomment-932759976


   Hm... The `DefaultStatefulSingleton` it makes no sense to define the property `final` because the attribute itself is not given outside...it will not prevent anything not make things in any way better..Also all this `final` in front of `String` class makes also no sense ...apart from that the attributes which are defined as `@parameter` I would expect to produce some errors? If I correctly remember....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org