You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by xi...@apache.org on 2020/10/04 07:04:28 UTC
[incubator-pinot] 01/01: Fix missing segment count reporting for
realtime llc segment
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch fixing_realtime_segment_cnt_metric
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit a40afe784e671c849c9eab8958b03e4019112ae5
Author: Xiang Fu <fx...@gmail.com>
AuthorDate: Sun Oct 4 00:04:05 2020 -0700
Fix missing segment count reporting for realtime llc segment
---
.../pinot/core/data/manager/realtime/RealtimeTableDataManager.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
index edfef0d..b451a5c 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
@@ -39,6 +39,7 @@ import org.apache.pinot.common.metadata.ZKMetadataProvider;
import org.apache.pinot.common.metadata.instance.InstanceZKMetadata;
import org.apache.pinot.common.metadata.segment.LLCRealtimeSegmentZKMetadata;
import org.apache.pinot.common.metadata.segment.RealtimeSegmentZKMetadata;
+import org.apache.pinot.common.metrics.ServerGauge;
import org.apache.pinot.common.utils.CommonConstants;
import org.apache.pinot.common.utils.CommonConstants.Segment.Realtime.Status;
import org.apache.pinot.common.utils.LLCSegmentName;
@@ -216,7 +217,6 @@ public class RealtimeTableDataManager extends BaseTableDataManager {
_tableNameWithType, segmentDataManager.getClass().getSimpleName());
return;
}
-
RealtimeSegmentZKMetadata realtimeSegmentZKMetadata =
ZKMetadataProvider.getRealtimeSegmentZKMetadata(_propertyStore, _tableNameWithType, segmentName);
Preconditions.checkNotNull(realtimeSegmentZKMetadata);
@@ -269,6 +269,7 @@ public class RealtimeTableDataManager extends BaseTableDataManager {
}
_logger.info("Initialize RealtimeSegmentDataManager - " + segmentName);
_segmentDataManagerMap.put(segmentName, manager);
+ _serverMetrics.addValueToTableGauge(_tableNameWithType, ServerGauge.SEGMENT_COUNT, 1L);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org