You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Shwetha GS <ss...@hortonworks.com> on 2015/07/30 11:33:21 UTC
Review Request 36935: ATLAS-86 Jenkins build failing as of build #41
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36935/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-86
https://issues.apache.org/jira/browse/ATLAS-86
Repository: atlas
Description
-------
Main changes:
1. Moved security tests from hive-bridge module to webapp
2. In security tests - moved common code out to base classes, changed the keystore/war paths to absolute paths, writing application/client properties to random target
3. commons-configuration 1.10 already supports variables. So, removed manual handling of variables
Diffs
-----
addons/hive-bridge/pom.xml 117d76c
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java 11163c8
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java 891e06c
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java 7471680
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java b114d5a
client/pom.xml be19a71
client/src/main/java/org/apache/atlas/ApplicationProperties.java ad87d8d
client/src/main/java/org/apache/atlas/security/SecureClientUtils.java b70c5ce
client/src/test/resources/application.properties 9672d1e
pom.xml c201b4c
src/conf/application.properties 51f2529
webapp/pom.xml 86e1ebf
webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java ca71293
webapp/src/test/java/org/apache/atlas/web/TestUtils.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 67f3901
webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosIT.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosIT.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/security/SSLIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/36935/diff/
Testing
-------
UTs
Thanks,
Shwetha GS
Re: Review Request 36935: ATLAS-86 Jenkins build failing as of build
#41
Posted by Jonathan Maron <jm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36935/#review93582
-----------------------------------------------------------
Ship it!
- Jonathan Maron
On July 30, 2015, 12:38 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36935/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 12:38 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-86
> https://issues.apache.org/jira/browse/ATLAS-86
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Main changes:
> 1. Moved security tests from hive-bridge module to webapp
> 2. In security tests - moved common code out to base classes, changed the keystore/war paths to absolute paths, writing application/client properties to random target
> 3. commons-configuration 1.10 already supports variables. So, removed manual handling of variables
>
>
> Diffs
> -----
>
> addons/hive-bridge/pom.xml 117d76c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java 11163c8
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java 891e06c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java 7471680
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java b114d5a
> client/pom.xml be19a71
> client/src/main/java/org/apache/atlas/ApplicationProperties.java ad87d8d
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java b70c5ce
> client/src/test/resources/application.properties 9672d1e
> pom.xml c201b4c
> src/conf/application.properties 51f2529
> webapp/pom.xml 86e1ebf
> webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java ca71293
> webapp/src/test/java/org/apache/atlas/web/TestUtils.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 67f3901
> webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36935/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 36935: ATLAS-86 Jenkins build failing as of build
#41
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36935/
-----------------------------------------------------------
(Updated July 30, 2015, 12:38 p.m.)
Review request for atlas.
Changes
-------
Fixed typos in config
Bugs: ATLAS-86
https://issues.apache.org/jira/browse/ATLAS-86
Repository: atlas
Description
-------
Main changes:
1. Moved security tests from hive-bridge module to webapp
2. In security tests - moved common code out to base classes, changed the keystore/war paths to absolute paths, writing application/client properties to random target
3. commons-configuration 1.10 already supports variables. So, removed manual handling of variables
Diffs (updated)
-----
addons/hive-bridge/pom.xml 117d76c
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java 11163c8
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java 891e06c
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java 7471680
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java b114d5a
client/pom.xml be19a71
client/src/main/java/org/apache/atlas/ApplicationProperties.java ad87d8d
client/src/main/java/org/apache/atlas/security/SecureClientUtils.java b70c5ce
client/src/test/resources/application.properties 9672d1e
pom.xml c201b4c
src/conf/application.properties 51f2529
webapp/pom.xml 86e1ebf
webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java ca71293
webapp/src/test/java/org/apache/atlas/web/TestUtils.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 67f3901
webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosIT.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosIT.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/security/SSLIT.java PRE-CREATION
Diff: https://reviews.apache.org/r/36935/diff/
Testing
-------
UTs
Thanks,
Shwetha GS
Re: Review Request 36935: ATLAS-86 Jenkins build failing as of build
#41
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36935/#review93572
-----------------------------------------------------------
src/conf/application.properties (line 43)
<https://reviews.apache.org/r/36935/#comment147957>
{ is missing
- Suma Shivaprasad
On July 30, 2015, 9:33 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36935/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 9:33 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-86
> https://issues.apache.org/jira/browse/ATLAS-86
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Main changes:
> 1. Moved security tests from hive-bridge module to webapp
> 2. In security tests - moved common code out to base classes, changed the keystore/war paths to absolute paths, writing application/client properties to random target
> 3. commons-configuration 1.10 already supports variables. So, removed manual handling of variables
>
>
> Diffs
> -----
>
> addons/hive-bridge/pom.xml 117d76c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java 11163c8
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java 891e06c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java 7471680
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java b114d5a
> client/pom.xml be19a71
> client/src/main/java/org/apache/atlas/ApplicationProperties.java ad87d8d
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java b70c5ce
> client/src/test/resources/application.properties 9672d1e
> pom.xml c201b4c
> src/conf/application.properties 51f2529
> webapp/pom.xml 86e1ebf
> webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java ca71293
> webapp/src/test/java/org/apache/atlas/web/TestUtils.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 67f3901
> webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36935/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 36935: ATLAS-86 Jenkins build failing as of build
#41
Posted by Shwetha GS <ss...@hortonworks.com>.
> On July 30, 2015, 11:30 a.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/ApplicationProperties.java, line 94
> > <https://reviews.apache.org/r/36935/diff/1/?file=1025020#file1025020line94>
> >
> > why is this removed? Not needed now?
Looks like commons-configuration 1.10 supports variables already. I had looked at wrong docs earlier
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36935/#review93571
-----------------------------------------------------------
On July 30, 2015, 9:33 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36935/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 9:33 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-86
> https://issues.apache.org/jira/browse/ATLAS-86
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Main changes:
> 1. Moved security tests from hive-bridge module to webapp
> 2. In security tests - moved common code out to base classes, changed the keystore/war paths to absolute paths, writing application/client properties to random target
> 3. commons-configuration 1.10 already supports variables. So, removed manual handling of variables
>
>
> Diffs
> -----
>
> addons/hive-bridge/pom.xml 117d76c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java 11163c8
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java 891e06c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java 7471680
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java b114d5a
> client/pom.xml be19a71
> client/src/main/java/org/apache/atlas/ApplicationProperties.java ad87d8d
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java b70c5ce
> client/src/test/resources/application.properties 9672d1e
> pom.xml c201b4c
> src/conf/application.properties 51f2529
> webapp/pom.xml 86e1ebf
> webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java ca71293
> webapp/src/test/java/org/apache/atlas/web/TestUtils.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 67f3901
> webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36935/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 36935: ATLAS-86 Jenkins build failing as of build
#41
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36935/#review93571
-----------------------------------------------------------
client/src/main/java/org/apache/atlas/ApplicationProperties.java
<https://reviews.apache.org/r/36935/#comment147956>
why is this removed? Not needed now?
- Suma Shivaprasad
On July 30, 2015, 9:33 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36935/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 9:33 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-86
> https://issues.apache.org/jira/browse/ATLAS-86
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Main changes:
> 1. Moved security tests from hive-bridge module to webapp
> 2. In security tests - moved common code out to base classes, changed the keystore/war paths to absolute paths, writing application/client properties to random target
> 3. commons-configuration 1.10 already supports variables. So, removed manual handling of variables
>
>
> Diffs
> -----
>
> addons/hive-bridge/pom.xml 117d76c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java 11163c8
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java 891e06c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java 7471680
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java b114d5a
> client/pom.xml be19a71
> client/src/main/java/org/apache/atlas/ApplicationProperties.java ad87d8d
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java b70c5ce
> client/src/test/resources/application.properties 9672d1e
> pom.xml c201b4c
> src/conf/application.properties 51f2529
> webapp/pom.xml 86e1ebf
> webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java ca71293
> webapp/src/test/java/org/apache/atlas/web/TestUtils.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 67f3901
> webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36935/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 36935: ATLAS-86 Jenkins build failing as of build
#41
Posted by Shwetha GS <ss...@hortonworks.com>.
> On July 30, 2015, 11:38 a.m., Suma Shivaprasad wrote:
> > Can we run tests in distributed mode once?
I haven't changed any third party dependencies, so shouldn't affect?
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36935/#review93574
-----------------------------------------------------------
On July 30, 2015, 12:38 p.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36935/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 12:38 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-86
> https://issues.apache.org/jira/browse/ATLAS-86
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Main changes:
> 1. Moved security tests from hive-bridge module to webapp
> 2. In security tests - moved common code out to base classes, changed the keystore/war paths to absolute paths, writing application/client properties to random target
> 3. commons-configuration 1.10 already supports variables. So, removed manual handling of variables
>
>
> Diffs
> -----
>
> addons/hive-bridge/pom.xml 117d76c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java 11163c8
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java 891e06c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java 7471680
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java b114d5a
> client/pom.xml be19a71
> client/src/main/java/org/apache/atlas/ApplicationProperties.java ad87d8d
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java b70c5ce
> client/src/test/resources/application.properties 9672d1e
> pom.xml c201b4c
> src/conf/application.properties 51f2529
> webapp/pom.xml 86e1ebf
> webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java ca71293
> webapp/src/test/java/org/apache/atlas/web/TestUtils.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 67f3901
> webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36935/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 36935: ATLAS-86 Jenkins build failing as of build
#41
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36935/#review93574
-----------------------------------------------------------
Can we run tests in distributed mode once?
- Suma Shivaprasad
On July 30, 2015, 9:33 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36935/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 9:33 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-86
> https://issues.apache.org/jira/browse/ATLAS-86
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Main changes:
> 1. Moved security tests from hive-bridge module to webapp
> 2. In security tests - moved common code out to base classes, changed the keystore/war paths to absolute paths, writing application/client properties to random target
> 3. commons-configuration 1.10 already supports variables. So, removed manual handling of variables
>
>
> Diffs
> -----
>
> addons/hive-bridge/pom.xml 117d76c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java 11163c8
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/NegativeSSLAndKerberosHiveHookIT.java 891e06c
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLAndKerberosHiveHookIT.java 7471680
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java b114d5a
> client/pom.xml be19a71
> client/src/main/java/org/apache/atlas/ApplicationProperties.java ad87d8d
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java b70c5ce
> client/src/test/resources/application.properties 9672d1e
> pom.xml c201b4c
> src/conf/application.properties 51f2529
> webapp/pom.xml 86e1ebf
> webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java ca71293
> webapp/src/test/java/org/apache/atlas/web/TestUtils.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 67f3901
> webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosIT.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/security/SSLIT.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36935/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>