Re: [PR] HDDS-9348. Improving parsing speed of DB Scanner [ozone]

["kerneltime (via GitHub)" <gi...@apache.org>]

kerneltime commented on code in PR #5358:
URL: https://github.com/apache/ozone/pull/5358#discussion_r1342891134


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java:
##########
@@ -114,9 +131,18 @@ public class DBScanner implements Callable<Void>, SubcommandWithParent {
       showDefaultValue = CommandLine.Help.Visibility.ALWAYS)
   private boolean showCount;
 
-  private String keySeparatorSchemaV3 =
+  @CommandLine.Option(names = {"--compact"},
+      description = "disable the pretty print the output",
+      defaultValue = "false")
+  private static boolean compact;
+
+  private static final String KEY_SEPARATOR_SCHEMA_V3 =
       new OzoneConfiguration().getObject(DatanodeConfiguration.class)
           .getContainerSchemaV3KeySeparator();
+  private static final int BATCH_SIZE = 10000;
+  private static final int THREAD_COUNT = 10;

Review Comment:
   Why not make these optional params as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org