You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Tao Feng (JIRA)" <ji...@apache.org> on 2019/04/24 05:00:05 UTC

[jira] [Commented] (AIRFLOW-4402) Update super() calls for nvd3

    [ https://issues.apache.org/jira/browse/AIRFLOW-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824820#comment-16824820 ] 

Tao Feng commented on AIRFLOW-4402:
-----------------------------------

hold on, I don't think we should change any of the files under vendor folder as all the file under that folder meant to be copy paste from upstream dependency. 

> Update super() calls for nvd3
> -----------------------------
>
>                 Key: AIRFLOW-4402
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4402
>             Project: Apache Airflow
>          Issue Type: Sub-task
>            Reporter: Chao-Han Tsai
>            Assignee: Chao-Han Tsai
>            Priority: Major
>             Fix For: 2.0.0
>
>
> In all classes under nvd3, replace {{super(__class__, self).__init__(...)}} by {{super().__init__(...)}}
> Similarly for any other {{super}} calls for other methods.
> (In Python 3 {{super(__class__, self) == super()}})



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)