You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2006/02/05 20:03:25 UTC
This commit needs a review (WAS: svn commit: r375077 - in /tomcat/connectors/trunk/jk:
native/iis/jk_isapi_plugin.c xdocs/changelog.xml)
My C is very rusty. I *think* this is OK and doesn't do anything
dangerous but I would be grateful if someone could review it.
Cheers,
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: This commit needs a review (WAS: svn commit: r375077 - in /tomcat/connectors/trunk/jk: native/iis/jk_isapi_plugin.c xdocs/changelog.xml)
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Feb 5, 2006, at 2:03 PM, Mark Thomas wrote:
> My C is very rusty. I *think* this is OK and doesn't do anything
> dangerous but I would be grateful if someone could review it.
>
It looks like this just handles the case where pfc->pFilterContext
isn't NULL, which means memory has already been allocated for
it. As such, except for the allocation in the if-part,
the logic should flow the exact same way, so +1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org