You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/13 08:55:21 UTC

[GitHub] [pulsar] eolivelli opened a new pull request #13268: Broker: brokerDeduplicationSnapshotFrequencyInSeconds default should be 10

eolivelli opened a new pull request #13268:
URL: https://github.com/apache/pulsar/pull/13268


   ### Motivation
   In the default configuration file `conf/broker.conf` the entry `brokerDeduplicationSnapshotFrequencyInSeconds` is 10, 
   but in the Java code the default is 120.
   So if you comment out or you remove that line in broker.conf the behaviour of the broker changes.
   
   ### Modifications
   Change the default value from 120 to 10. 
   
   An alternative could be to change broker.conf, but doing so if you upgrade the Pulsar docker image you would see an unexpected behaviour change, so it is better to change the Java value.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #13268: Broker: brokerDeduplicationSnapshotFrequencyInSeconds default should be 10

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #13268:
URL: https://github.com/apache/pulsar/pull/13268#issuecomment-992279392


   > LGTM, could you please help add a test to avoid the regression?
   This is a very valid point, as we don't have tests for every default value.
   
   I am sorry but I don't have time this week. I could create an issue and follow up in the future.
   What do you think ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #13268: Broker: brokerDeduplicationSnapshotFrequencyInSeconds default should be 10

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #13268:
URL: https://github.com/apache/pulsar/pull/13268#issuecomment-992386584


   > I could create an issue and follow up in the future.
   
   This entry is missing in doc too. See https://pulsar.apache.org/docs/en/reference-configuration/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli closed pull request #13268: Broker: brokerDeduplicationSnapshotFrequencyInSeconds default should be 10

Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #13268:
URL: https://github.com/apache/pulsar/pull/13268


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #13268: Broker: brokerDeduplicationSnapshotFrequencyInSeconds default should be 10

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13268:
URL: https://github.com/apache/pulsar/pull/13268#issuecomment-1051439341


   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #13268: Broker: brokerDeduplicationSnapshotFrequencyInSeconds default should be 10

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #13268:
URL: https://github.com/apache/pulsar/pull/13268#issuecomment-992448094


   I extended this fix here: https://github.com/apache/pulsar/pull/13272 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 commented on pull request #13268: Broker: brokerDeduplicationSnapshotFrequencyInSeconds default should be 10

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #13268:
URL: https://github.com/apache/pulsar/pull/13268#issuecomment-993078807


   We'd better keep it 120s, 10s is too short.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org