[GitHub] [spark] HyukjinKwon commented on a change in pull request #34211: [SPARK-36946][PYTHON] Support time for ps.to_datetime

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34211:
URL: https://github.com/apache/spark/pull/34211#discussion_r728560800



##########
File path: python/pyspark/pandas/namespace.py
##########
@@ -1652,7 +1664,7 @@ def f(value):
 

Review comment:
       Can we just do:
   
   ```python
       def f(value):
           if value.lower() in _unit_map:
               return _unit_map[value.lower()]
           return value
   ```
   
   ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org