[GitHub] [maven] gnodet edited a comment on pull request #703: New API with immutable model

[GitBox <gi...@apache.org>]

gnodet edited a comment on pull request #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1085598999


   > Yes I saw the MDO.
   
   So the objects *are* immutable, they absolutely can not be modified.
   
   So unless we raise the requirements to JDK 17, I don't see how we could actually use records / List.of().  That said, I'm not sure there's actually much difference at the end.  Of course, using records would be less verbose, but given we don't have to maintain that code manually (because it's generated), I'm not sure it really matters.  For the `List.of(x)` point, the model already uses immutable lists, though those use `Collections.unmodifiableList(xxx)` to be JDK 8 compatible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org