[GitHub] [spark] LuciferYang commented on pull request #42465: [CONNECT][POC] Have real server and real simple client in tests - classpath order hack

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on PR #42465:
URL: https://github.com/apache/spark/pull/42465#issuecomment-1677111533

   On the other hand, when build with Maven, this change will change the build order of the `client` module and the `server` module
   
   Before
   
   ```
   [INFO] Spark Project Connect Server ....................... SUCCESS [  0.001 s]
   [INFO] Spark Project Connect Client ....................... SUCCESS [  0.001 s]
   ```
   
   After
   
   ```
   [INFO] Spark Project Connect Client ....................... SUCCESS [  0.066 s]
   [INFO] Spark Project Connect Server ....................... SUCCESS [  0.049 s]
   ```
   
   However, in the client module, test cases that inherit `RemoteSparkSession` depend on the output of the server module. If the build order is changed, more refactoring work is needed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org