You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "labuladong (via GitHub)" <gi...@apache.org> on 2023/01/29 04:32:16 UTC

[GitHub] [pulsar] labuladong opened a new pull request, #19347: [fix][test] broker.admin.PersistentTopicsTest#testUnloadTopic

labuladong opened a new pull request, #19347:
URL: https://github.com/apache/pulsar/pull/19347

   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   -->
   
   <!-- Either this PR fixes an issue, -->
   
   Fixes #19265
   
   <!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md -->
   
   ### Modifications
   
   Reset mock object before reuse.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- closed pull request #19347: [fix][test] broker.admin.PersistentTopicsTest#testUnloadTopic

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #19347: [fix][test] broker.admin.PersistentTopicsTest#testUnloadTopic
URL: https://github.com/apache/pulsar/pull/19347


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #19347: [fix][test] broker.admin.PersistentTopicsTest#testUnloadTopic

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #19347:
URL: https://github.com/apache/pulsar/pull/19347


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codecov-commenter commented on pull request #19347: [fix][test] broker.admin.PersistentTopicsTest#testUnloadTopic

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19347:
URL: https://github.com/apache/pulsar/pull/19347#issuecomment-1407610932

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19347](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ec2fb1) into [master](https://codecov.io/gh/apache/pulsar/commit/c875365c648584910b1b2de4cf8492121f4e0c4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c875365) will **decrease** coverage by `0.64%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/19347/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19347      +/-   ##
   ============================================
   - Coverage     63.28%   62.64%   -0.64%     
   - Complexity     3583    26225   +22642     
   ============================================
     Files          1893     1895       +2     
     Lines        137452   137529      +77     
     Branches      15091    15098       +7     
   ============================================
   - Hits          86982    86154     -828     
   - Misses        42615    43410     +795     
   - Partials       7855     7965     +110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | inttests | `23.97% <ø> (-0.07%)` | :arrow_down: |
   | systests | `24.80% <ø> (-0.06%)` | :arrow_down: |
   | unittests | `60.56% <ø> (-0.47%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/pulsar/client/api/ServiceUrlProvider.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jbGllbnQvYXBpL1NlcnZpY2VVcmxQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...lsar/client/impl/auth/AuthenticationDataBasic.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL2F1dGgvQXV0aGVudGljYXRpb25EYXRhQmFzaWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../stats/prometheus/AggregatedSubscriptionStats.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9wcm9tZXRoZXVzL0FnZ3JlZ2F0ZWRTdWJzY3JpcHRpb25TdGF0cy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...metheus/AggregatedTransactionCoordinatorStats.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9wcm9tZXRoZXVzL0FnZ3JlZ2F0ZWRUcmFuc2FjdGlvbkNvb3JkaW5hdG9yU3RhdHMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...broker/stats/prometheus/TransactionAggregator.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9wcm9tZXRoZXVzL1RyYW5zYWN0aW9uQWdncmVnYXRvci5qYXZh) | `0.00% <0.00%> (-96.06%)` | :arrow_down: |
   | [.../impl/auth/oauth2/AuthenticationFactoryOAuth2.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL2F1dGgvb2F1dGgyL0F1dGhlbnRpY2F0aW9uRmFjdG9yeU9BdXRoMi5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
   | [.../apache/pulsar/utils/CmdGenerateDocumentation.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3V0aWxzL0NtZEdlbmVyYXRlRG9jdW1lbnRhdGlvbi5qYXZh) | `0.00% <0.00%> (-76.93%)` | :arrow_down: |
   | [...ker/stats/prometheus/AggregatedNamespaceStats.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9wcm9tZXRoZXVzL0FnZ3JlZ2F0ZWROYW1lc3BhY2VTdGF0cy5qYXZh) | `5.20% <0.00%> (-76.05%)` | :arrow_down: |
   | [...ar/broker/stats/prometheus/ManagedLedgerStats.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9wcm9tZXRoZXVzL01hbmFnZWRMZWRnZXJTdGF0cy5qYXZh) | `28.57% <0.00%> (-71.43%)` | :arrow_down: |
   | [...e/pulsar/client/impl/auth/AuthenticationBasic.java](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL2F1dGgvQXV0aGVudGljYXRpb25CYXNpYy5qYXZh) | `0.00% <0.00%> (-69.24%)` | :arrow_down: |
   | ... and [212 more](https://codecov.io/gh/apache/pulsar/pull/19347?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org