You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/05 13:55:20 UTC

[GitHub] sijie commented on a change in pull request #3308: Add heartbeat interval for kafka connector

sijie commented on a change in pull request #3308: Add heartbeat interval for kafka connector
URL: https://github.com/apache/pulsar/pull/3308#discussion_r245478536
 
 

 ##########
 File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java
 ##########
 @@ -69,6 +69,11 @@
         help =
             "The timeout used to detect failures when using Kafka's group management facilities.")
     private long sessionTimeoutMs = 30000L;
+    @FieldDoc(
+        defaultValue = "3000",
+        help =
+            "The interval between heartbeats to the consumer when using Kafka's group management facilities.")
 
 Review comment:
   can you highlight that hearbeat interval need to be less than session timeout ms?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services