You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/10/05 04:11:52 UTC
[Impala-ASF-CR] IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11592
Change subject: IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
......................................................................
IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Empty value in sentry.db.explicit.grants.permitted means allow all
privileges to be explicitly granted. However a bug in SENTRY-2424
causes empty value to be ignored. The patch uses a workaround to add
a space to mean the same thing as an empty value. The patch also
upgrades CDH_BUILD_NUMBER to 618371 to enable
sentry.db.explicit.grants.permitted configuration.
Testing:
- Ran all core tests
Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
---
M bin/impala-config.sh
M fe/src/test/resources/sentry-site.xml.template
M fe/src/test/resources/sentry-site_no_oo.xml.template
M fe/src/test/resources/sentry-site_oo.xml.template
M fe/src/test/resources/sentry-site_oo_nogrant.xml.template
5 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/11592/1
--
To view, visit http://gerrit.cloudera.org:8080/11592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11592 )
Change subject: IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
......................................................................
IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Empty value in sentry.db.explicit.grants.permitted means allow all
privileges to be explicitly granted. However a bug in SENTRY-2424
causes empty value to be ignored. The patch uses a workaround to add
a space to mean the same thing as an empty value. The patch also
upgrades CDH_BUILD_NUMBER to 618371 to enable
sentry.db.explicit.grants.permitted configuration.
Testing:
- Ran all core tests
Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Reviewed-on: http://gerrit.cloudera.org:8080/11592
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M fe/src/test/resources/sentry-site.xml.template
M fe/src/test/resources/sentry-site_no_oo.xml.template
M fe/src/test/resources/sentry-site_oo.xml.template
M fe/src/test/resources/sentry-site_oo_nogrant.xml.template
5 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11592 )
Change subject: IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/957/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 04:42:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11592 )
Change subject: IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3277/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/11592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 04:12:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11592 )
Change subject: IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 09:34:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11592 )
Change subject: IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 08:03:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11592 )
Change subject: IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 15:09:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11592 )
Change subject: IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 19:07:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11592 )
Change subject: IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3280/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Gerrit-Change-Number: 11592
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 15:09:59 +0000
Gerrit-HasComments: No