You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/04 23:23:50 UTC
[GitHub] [netbeans] mcdonnell-john opened a new pull request #3699: [3697] Removed invalid cpp package reference and introduces support for sign…
mcdonnell-john opened a new pull request #3699:
URL: https://github.com/apache/netbeans/pull/3699
…ing the .app with an Application Cert
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mcdonnell-john commented on pull request #3699: [3697] Removed invalid cpp package reference and introduces support for sign…
Posted by GitBox <gi...@apache.org>.
mcdonnell-john commented on pull request #3699:
URL: https://github.com/apache/netbeans/pull/3699#issuecomment-1063174456
Just seeing this now...
> Thanks @mcdonnell-john Looks like my concerns about notarization issues are starting to realise! 😄
>
Yeah :)
> There's no need for the GitHub issue ( #3697 ) - PR fine - linking in so we have the log.
>
I'll close the issue then, wasnt sure if I needed an issue to link to a PR or not.
> Do these changes get notarization to pass? I'm surprised it's not erroring with other libs in jars - eg. JNA. Also, including x86 libs and/or ~lack of hardened runtime being allowed through~? This seems like it still wouldn't meet the "requirements" at https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution ??
>
Yes, they are passing notarization, however its worth pointing out the notarization logs to call out a warning on other .pkg files, so I might need to raise another ticket with Apple as the notarization log doesn't provide any feedback on what those warnings are about.
I'm not sure about the entitlements, I can take a further look before doing any release(just incase)
> Base branch is master. Can you build from NetBeans 13 release using master? Or do we need to merge to delivery and then release branch?
>
If I go with the approach in the email thread I will keep this against master as I don't think we need to rebuild 13, I will generate the new distpreparations zip myself.
> EDIT: Sorry, just noticed you do have `--options runtime`, but does it need an entitlements file if we do this?
Nothing came up when I added this in, however based on what I've learned to date that means nothing 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3699: [3697] Removed invalid cpp package reference and introduces support for sign…
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #3699:
URL: https://github.com/apache/netbeans/pull/3699#issuecomment-1060501046
Thanks @mcdonnell-john Looks like my concerns about notarization issues are starting to realise! :smile:
There's no need for the GitHub issue ( #3697 ) - PR fine - linking in so we have the log.
Do these changes get notarization to pass? I'm surprised it's not erroring with other libs in jars - eg. JNA. Also, including x86 libs and/or ~~lack of hardened runtime being allowed through~~? This seems like it still wouldn't meet the "requirements" at https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution ??
Base branch is master. Can you build from NetBeans 13 release using master? Or do we need to merge to delivery and then release branch?
EDIT: Sorry, just noticed you do have `--options runtime`, but does it need an entitlements file if we do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mcdonnell-john merged pull request #3699: [3697] Removed invalid cpp package reference and introduces support for sign…
Posted by GitBox <gi...@apache.org>.
mcdonnell-john merged pull request #3699:
URL: https://github.com/apache/netbeans/pull/3699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3699: [3697] Removed invalid cpp package reference and introduces support for sign…
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3699:
URL: https://github.com/apache/netbeans/pull/3699#issuecomment-1060501046
Thanks @mcdonnell-john Looks like my concerns about notarization issues are starting to realise! :smile:
There's no need for the GitHub issue ( #3697 ) - PR fine - linking in so we have the log.
Do these changes get notarization to pass? I'm surprised it's not erroring with other libs in jars - eg. JNA. Also, including x86 libs and/or lack of hardened runtime being allowed through? This seems like it still wouldn't meet the "requirements" at https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution ??
Base branch is master. Can you build from NetBeans 13 release using master? Or do we need to merge to delivery and then release branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mcdonnell-john edited a comment on pull request #3699: [3697] Removed invalid cpp package reference and introduces support for sign…
Posted by GitBox <gi...@apache.org>.
mcdonnell-john edited a comment on pull request #3699:
URL: https://github.com/apache/netbeans/pull/3699#issuecomment-1063174456
Just seeing this now...
> Thanks @mcdonnell-john Looks like my concerns about notarization issues are starting to realise! 😄
>
Yeah :)
> There's no need for the GitHub issue ( #3697 ) - PR fine - linking in so we have the log.
>
I'll close the issue then, wasnt sure if I needed an issue to link to a PR or not.
> Do these changes get notarization to pass? I'm surprised it's not erroring with other libs in jars - eg. JNA. Also, including x86 libs and/or ~lack of hardened runtime being allowed through~? This seems like it still wouldn't meet the "requirements" at https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution ??
>
Yes, they are passing notarization, however its worth pointing out the notarization logs to call out a warning on other .pkg files, so I might need to raise another ticket with Apple as the notarization log doesn't provide any feedback on what those warnings are about.
I'm not sure about the entitlements, I can take a further look before doing any release(just incase)
> Base branch is master. Can you build from NetBeans 13 release using master? Or do we need to merge to delivery and then release branch?
>
If I go with the approach in the email thread I will keep this against master as I don't think we need to rebuild 13, I will generate the new distpreparations zip myself.
> EDIT: Sorry, just noticed you do have `--options runtime`, but does it need an entitlements file if we do this?
Nothing came up when I added this in, however based on what I've learned to date that means nothing 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mcdonnell-john commented on pull request #3699: [3697] Removed invalid cpp package reference and introduces support for sign…
Posted by GitBox <gi...@apache.org>.
mcdonnell-john commented on pull request #3699:
URL: https://github.com/apache/netbeans/pull/3699#issuecomment-1059601457
Also related: https://github.com/apache/netbeans-jenkins-lib/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists