You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/04/30 22:40:41 UTC
[PR] docs: add benchmarking guide for contributors [datafusion-ballista]
andygrove opened a new pull request, #1631:
URL: https://github.com/apache/datafusion-ballista/pull/1631
# Which issue does this PR close?
Closes #.
# Rationale for this change
The current `Benchmarking` section in the contributor development guide is a single paragraph that links out to `benchmarks/README.md`. The README is comprehensive on setup (TPC-H data generation, docker-compose, Spark comparison) but does not address the day-to-day contributor workflow: which benchmark to reach for when working on a specific change, how to read the metrics each one prints, and how to capture a flame graph when something is unexpectedly slow. The standalone `shuffle_bench` binary added in #1600 is also not documented anywhere in the user-visible docs.
# What changes are included in this PR?
- New page `docs/source/contributors-guide/benchmarking.md` with sections covering:
- A decision guide for picking between the TPC-H runner, NYC taxi binary, the standalone `shuffle_bench`, and the `sort_shuffle` Criterion bench
- TPC-H input generation with `tpchgen-rs`
- Running each benchmark, including the Criterion `--save-baseline` / `--baseline` flow
- Reading the shuffle metrics (`input_rows`, `write_time`, `spill_count`, `repart_time`)
- Profiling with `cargo flamegraph` and `samply`
- A short note on when to add a Criterion bench vs a binary
- The `Benchmarking` section in `contributors-guide/development.md` now points at the new page and keeps the link to the comprehensive `benchmarks/README.md`
- The new page is registered in the `index.rst` toctree under Contributors Guide
# Are there any user-facing changes?
Documentation only. No code or API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(benchmarks): add --config to tpch datafusion + contributor guide [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #1631:
URL: https://github.com/apache/datafusion-ballista/pull/1631#issuecomment-5645555514
@andygrove is this PR still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(benchmarks): add --config to tpch datafusion + contributor guide [datafusion-ballista]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #1631:
URL: https://github.com/apache/datafusion-ballista/pull/1631#issuecomment-6483751390
Closing as stale. Most benchmark binaries have a `-c key=value` flag now. The `tpch benchmark datafusion` subcommand is the remaining gap, and that's easier to redo on current main than to rebase this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(benchmarks): add --config to tpch datafusion + contributor guide [datafusion-ballista]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed pull request #1631: feat(benchmarks): add --config to tpch datafusion + contributor guide
URL: https://github.com/apache/datafusion-ballista/pull/1631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org