You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by bu...@apache.org on 2009/01/05 02:35:21 UTC

DO NOT REPLY [Bug 46473] New: Code that uses BaseScriptingEnvironment.createWindow() now won't compile

https://issues.apache.org/bugzilla/show_bug.cgi?id=46473

           Summary: Code that uses BaseScriptingEnvironment.createWindow()
                    now won't compile
           Product: Batik
           Version: 1.8
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Bridge
        AssignedTo: batik-dev@xmlgraphics.apache.org
        ReportedBy: cam@apache.org


In r665947 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=665947 ) BaseScriptingEnvironment.createWindow() was made protected.  Some
published code, such as the example at
http://xmlgraphics.apache.org/batik/using/scripting/java.html, uses this method
and assumes it's public.

The method should be made public once again, but rewritten so that a single
Window object only ever exists (so it will act like the getWindow() method does
now).  A new, different protected method that subclasses should override to
provide a concrete Window object should be used.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 46473] Code that uses BaseScriptingEnvironment.createWindow() now won't compile

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46473


Helder Magalhães <he...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gwadej@anomaly.org,
                   |                            |helder.magalhaes@gmail.com




--- Comment #1 from Helder Magalhães <he...@gmail.com>  2009-05-31 02:36:42 PST ---
(In reply to comment #0)
> In r665947, BaseScriptingEnvironment.createWindow() was made protected.  Some
> published code, such as the example at
> http://xmlgraphics.apache.org/batik/using/scripting/java.html, uses this method
> and assumes it's public.

Breaking documentation sample code it's always unfortunate... :-|


> The method should be made public once again, but rewritten so that a single
> Window object only ever exists (so it will act like the getWindow() method does
> now).  A new, different protected method that subclasses should override to
> provide a concrete Window object should be used.

I'm CC'ing G. Wade Johnson as I have a feeling this may also have something to
do with the Window improvements tracked in issue 46072 (in revision 712954 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=712954 )) and
he might be the right person to provide a patch, even if preliminary. ;-)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org