You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ds...@apache.org on 2017/11/01 00:12:38 UTC
[geode] branch feature/GEODE-3781 updated: moved stuff to internal
package
This is an automated email from the ASF dual-hosted git repository.
dschneider pushed a commit to branch feature/GEODE-3781
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/feature/GEODE-3781 by this push:
new 5983660 moved stuff to internal package
5983660 is described below
commit 5983660ed40d9838946c1686272503ad06a015b0
Author: Darrel Schneider <ds...@pivotal.io>
AuthorDate: Tue Oct 31 17:11:58 2017 -0700
moved stuff to internal package
---
.../java/org/apache/geode/connectors/jdbc/JDBCAsyncWriter.java | 2 ++
.../apache/geode/connectors/jdbc/{ => internal}/ColumnValue.java | 2 +-
.../geode/connectors/jdbc/{ => internal}/JDBCConfiguration.java | 4 ++--
.../apache/geode/connectors/jdbc/{ => internal}/JDBCManager.java | 4 ++--
.../geode/connectors/jdbc/JDBCAsyncWriterIntegrationTest.java | 7 -------
.../connectors/jdbc/{ => internal}/JDBCConfigurationUnitTest.java | 3 ++-
.../geode/connectors/jdbc/{ => internal}/JDBCManagerUnitTest.java | 4 +++-
7 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCAsyncWriter.java b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCAsyncWriter.java
index cad774d..12688d6 100644
--- a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCAsyncWriter.java
+++ b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCAsyncWriter.java
@@ -20,6 +20,8 @@ import java.util.Properties;
import org.apache.geode.cache.asyncqueue.AsyncEvent;
import org.apache.geode.cache.asyncqueue.AsyncEventListener;
import org.apache.geode.cache.query.internal.DefaultQuery;
+import org.apache.geode.connectors.jdbc.internal.JDBCConfiguration;
+import org.apache.geode.connectors.jdbc.internal.JDBCManager;
import org.apache.geode.internal.logging.LogService;
import org.apache.geode.pdx.PdxInstance;
import org.apache.logging.log4j.Logger;
diff --git a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/ColumnValue.java b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ColumnValue.java
similarity index 96%
rename from geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/ColumnValue.java
rename to geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ColumnValue.java
index fa540c2..1e7803e 100644
--- a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/ColumnValue.java
+++ b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ColumnValue.java
@@ -12,7 +12,7 @@
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
-package org.apache.geode.connectors.jdbc;
+package org.apache.geode.connectors.jdbc.internal;
public class ColumnValue {
final private boolean isKey;
diff --git a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCConfiguration.java b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/JDBCConfiguration.java
similarity index 96%
rename from geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCConfiguration.java
rename to geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/JDBCConfiguration.java
index e7a59bb..595c591 100644
--- a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCConfiguration.java
+++ b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/JDBCConfiguration.java
@@ -12,7 +12,7 @@
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
-package org.apache.geode.connectors.jdbc;
+package org.apache.geode.connectors.jdbc.internal;
import java.util.ArrayList;
import java.util.Arrays;
@@ -43,7 +43,7 @@ public class JDBCConfiguration {
private final String user;
private final String password;
- JDBCConfiguration(Properties configProps) {
+ public JDBCConfiguration(Properties configProps) {
validateKnownProperties(configProps);
validateRequiredProperties(configProps);
this.driver = configProps.getProperty(DRIVER);
diff --git a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCManager.java b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/JDBCManager.java
similarity index 99%
rename from geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCManager.java
rename to geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/JDBCManager.java
index 3440b38..4429add 100644
--- a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/JDBCManager.java
+++ b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/JDBCManager.java
@@ -12,7 +12,7 @@
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
-package org.apache.geode.connectors.jdbc;
+package org.apache.geode.connectors.jdbc.internal;
import java.sql.Connection;
import java.sql.DatabaseMetaData;
@@ -56,7 +56,7 @@ public class JDBCManager {
return result;
}
- JDBCManager(JDBCConfiguration config) {
+ public JDBCManager(JDBCConfiguration config) {
this.config = config;
}
diff --git a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCAsyncWriterIntegrationTest.java b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCAsyncWriterIntegrationTest.java
index a5efd6c..a3674c4 100644
--- a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCAsyncWriterIntegrationTest.java
+++ b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCAsyncWriterIntegrationTest.java
@@ -105,13 +105,6 @@ public class JDBCAsyncWriterIntegrationTest {
}
@Test
- public void canExecuteSQLOnDataBase() throws Exception {
- stmt.execute("Create Table blobTable" + " (testfield BLOB)");
- stmt.execute("Insert into blobTable values ('1', 'emp1', 10)");
- stmt.execute("Select * from blobTable");
- }
-
- @Test
public void validateJDBCAsyncWriterTotalEvents() {
Region employees = createRegionWithJDBCAsyncWriter(regionTableName, getRequiredProperties());
PdxInstance pdx1 = cache.createPdxInstanceFactory("Employee").writeString("name", "Emp1")
diff --git a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCConfigurationUnitTest.java b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/JDBCConfigurationUnitTest.java
similarity index 96%
rename from geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCConfigurationUnitTest.java
rename to geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/JDBCConfigurationUnitTest.java
index 1d32948..e35ec2e 100644
--- a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCConfigurationUnitTest.java
+++ b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/JDBCConfigurationUnitTest.java
@@ -12,12 +12,13 @@
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
-package org.apache.geode.connectors.jdbc;
+package org.apache.geode.connectors.jdbc.internal;
import static org.assertj.core.api.Assertions.*;
import java.util.Properties;
+import org.apache.geode.connectors.jdbc.internal.JDBCConfiguration;
import org.apache.geode.test.junit.categories.UnitTest;
import org.junit.*;
import org.junit.experimental.categories.Category;
diff --git a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCManagerUnitTest.java b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/JDBCManagerUnitTest.java
similarity index 99%
rename from geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCManagerUnitTest.java
rename to geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/JDBCManagerUnitTest.java
index 4491b04..e37c274 100644
--- a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/JDBCManagerUnitTest.java
+++ b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/JDBCManagerUnitTest.java
@@ -12,7 +12,7 @@
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
-package org.apache.geode.connectors.jdbc;
+package org.apache.geode.connectors.jdbc.internal;
import static org.assertj.core.api.Assertions.*;
import static org.mockito.Mockito.*;
@@ -35,6 +35,8 @@ import org.mockito.ArgumentCaptor;
import org.apache.geode.cache.Operation;
import org.apache.geode.cache.Region;
+import org.apache.geode.connectors.jdbc.internal.JDBCConfiguration;
+import org.apache.geode.connectors.jdbc.internal.JDBCManager;
import org.apache.geode.internal.cache.GemFireCacheImpl;
import org.apache.geode.pdx.PdxInstance;
import org.apache.geode.pdx.PdxInstanceFactory;
--
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <co...@geode.apache.org>'].