[jira] [Commented] (AMQ-6036) Too trivial check in SubQueueSelectorCacheBroker.hasWildcards

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996202#comment-14996202 ] 

ASF GitHub Bot commented on AMQ-6036:
-------------------------------------

GitHub user pdudits opened a pull request:

    https://github.com/apache/activemq/pull/156

    AMQ-6036: Parsing message selector for wildcard matches

    Parsing message selector for wildcard matches for ignoreWildcardSelectors feature.
    
    https://issues.apache.org/jira/browse/AMQ-6036

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pdudits/activemq amq-6036

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 201497448db49ea8921d8c4982f330fec171fd5f
Author: Patrik Dudits <pa...@dudits.net>
Date:   2015-11-09T08:18:16Z

    AMQ-6036: Parsing message selector for wildcard matches for ignoreWildcardSelectors feature
    
    https://issues.apache.org/jira/browse/AMQ-6036

----


> Too trivial check in SubQueueSelectorCacheBroker.hasWildcards
> -------------------------------------------------------------
>
>                 Key: AMQ-6036
>                 URL: https://issues.apache.org/jira/browse/AMQ-6036
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.12.1
>            Reporter: Patrik Dudits
>
> VirtualSelectorCache plugin cannot be reliably used when message selectors use e. g. literals with underscore like {{notificationType = 'NOTIFY_DELETE'}}.
> Full evaluation would need to walk the parsed selector, however the method should at least check for presence of {{LIKE}} case-insensitevely to return less false positives.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)