[jira] Commented: (MNG-3641) Lack of error checks on profiles

["Ian Springer (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MNG-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213203#action_213203 ] 

Ian Springer commented on MNG-3641:
-----------------------------------

The current warning message is:

"Profile with id: '" + explicitProfileId + "' has not been activated."

I think this message is misleading, because the profile actually is activated - it's just not used at all in the pom being processed. I suggest changing the message to something like:

"Profile with id '" + explicitProfileId + "' is activated, but this pom does not contain any usages of the profile."

Also, I don't think it makes sense to print this warning at all in a multi-module build. In the large multi-module project I work on, we have a number of profiles that are only used in a handful of the 50 or so modules.


> Lack of error checks on profiles
> --------------------------------
>
>                 Key: MNG-3641
>                 URL: http://jira.codehaus.org/browse/MNG-3641
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Profiles
>    Affects Versions: 2.0.9
>            Reporter: Kohsuke Kawaguchi
>            Assignee: Brett Porter
>             Fix For: 2.0.11, 2.1.0, 3.0-alpha-3
>
>         Attachments: MNG-3641-IT.tar.gz, MNG-3641-maven-project.patch, mng-3641.zip
>
>
> DefaultProfileManager performs no error checks on the profile IDs So If I specify bogus profile IDs from plugins (like {{mvn -P no-such-profile}}), Maven doesn't complain, and it just runs as if nothing was specified. This is very error prone.
> Also, I've seen some documentation that says deactivating a profile is "-P !profile". As far as I can tell from the code, this is wrong, but because of the lack of error check, such usage just gets ignored, and the user is left confused as to why the profile isn't deactivated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira