You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/11 16:13:31 UTC

[GitHub] [spark] wangyum opened a new pull request, #36848: [SPARK-39449][SQL] Propagate empty relation through Window

wangyum opened a new pull request, #36848:
URL: https://github.com/apache/spark/pull/36848

   ### What changes were proposed in this pull request?
   
   This PR adds support propagate empty relation through `Window`. For example:
   ```sql
   SELECT id,
          Count(*)
            OVER (
              ORDER BY id)
   FROM   (SELECT /*+ REPARTITION(3) */ *
           FROM   Range(100)
           WHERE  id < 0) t 
   ```
   
   After this PR:
   ```
   == Physical Plan ==
   AdaptiveSparkPlan (10)
   +- == Final Plan ==
      LocalTableScan (1)
   +- == Initial Plan ==
      CollectLimit (9)
      +- Project (8)
         +- Window (7)
            +- Sort (6)
               +- Exchange (5)
                  +- Exchange (4)
                     +- Filter (3)
                        +- Range (2)
   ```
   
   ### Why are the changes needed?
   
   Improve query performance.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #36848: [SPARK-39449][SQL] Propagate empty relation through Window

Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #36848:
URL: https://github.com/apache/spark/pull/36848#issuecomment-1163816151

   cc @sigmod @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #36848: [SPARK-39449][SQL] Propagate empty relation through Window

Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #36848:
URL: https://github.com/apache/spark/pull/36848#issuecomment-1165151206

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #36848: [SPARK-39449][SQL] Propagate empty relation through Window

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36848:
URL: https://github.com/apache/spark/pull/36848#issuecomment-1153331778

   cc @hvanhovell FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum closed pull request #36848: [SPARK-39449][SQL] Propagate empty relation through Window

Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #36848: [SPARK-39449][SQL] Propagate empty relation through Window
URL: https://github.com/apache/spark/pull/36848


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org