You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Thomas Neidhart (JIRA)" <ji...@apache.org> on 2015/03/10 22:00:41 UTC

[jira] [Resolved] (EMAIL-151) ImageHtmlEmail uses wrong name for embed() call

     [ https://issues.apache.org/jira/browse/EMAIL-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Neidhart resolved EMAIL-151.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.4

Fixed in r1665692. Thanks for the report and patch!

> ImageHtmlEmail uses wrong name for embed() call
> -----------------------------------------------
>
>                 Key: EMAIL-151
>                 URL: https://issues.apache.org/jira/browse/EMAIL-151
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.3.3
>            Reporter: Andreas Kohn
>             Fix For: 1.4
>
>         Attachments: email151-use-calculated-name-for-embed.diff
>
>
> Found by reading the code: ImageHtmlEmail#replacePattern() asks the DataSourceResolver for a DataSource, and if the name of the data source is null/empty uses the resource location as name for looking up the CID. 
> But, if that didn't work out it tries to embed the data source using the original 'null' name instead, which fails with an exception.
> Trivial patch attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)