You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Steven Yates <sy...@stevendyates.com> on 2014/02/25 11:50:20 UTC
Review Request 18460: SAMZA-97 : Remove unused queueSize variable from
TaskInstance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18460/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-97
https://issues.apache.org/jira/browse/SAMZA-97
Repository: samza
Description
-------
SAMZA-97, simple tidy up JIRA to remove an unnecessary constructor arg .
Diffs
-----
samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 974db63
Diff: https://reviews.apache.org/r/18460/diff/
Testing
-------
Thanks,
Steven Yates
Re: Review Request 18460: SAMZA-97 : Remove unused queueSize variable from
TaskInstance
Posted by Steven Yates <sy...@stevendyates.com>.
> On Feb. 25, 2014, 11:05 a.m., Garry Turkington wrote:
> > Looks good -- can you attach the patch to the Jira please?
Thanks Gary, done
- Steven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18460/#review35386
-----------------------------------------------------------
On Feb. 25, 2014, 10:50 a.m., Steven Yates wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18460/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 10:50 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-97
> https://issues.apache.org/jira/browse/SAMZA-97
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-97, simple tidy up JIRA to remove an unnecessary constructor arg .
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 974db63
>
> Diff: https://reviews.apache.org/r/18460/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steven Yates
>
>
Re: Review Request 18460: SAMZA-97 : Remove unused queueSize variable from
TaskInstance
Posted by Garry Turkington <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18460/#review35386
-----------------------------------------------------------
Ship it!
Looks good -- can you attach the patch to the Jira please?
- Garry Turkington
On Feb. 25, 2014, 10:50 a.m., Steven Yates wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18460/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 10:50 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-97
> https://issues.apache.org/jira/browse/SAMZA-97
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-97, simple tidy up JIRA to remove an unnecessary constructor arg .
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 974db63
>
> Diff: https://reviews.apache.org/r/18460/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steven Yates
>
>