You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "sschulze (via GitHub)" <gi...@apache.org> on 2023/06/08 23:13:11 UTC
[I] Possibility to inject custom ThreadContextStack implementation (logging-log4j2)
sschulze opened a new issue, #1507:
URL: https://github.com/apache/logging-log4j2/issues/1507
I'm looking for a way to inject a custom implementation of `ThreadContextStack` into the `ThreadContext`. There is already an injection mechanism for `ThreadContextMap` and the interface `ThreadContextStack` is in the SPI package but it looks like `ThreadContext` always directly instantiate the `DefaultThreadContextStack` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Possibility to inject custom ThreadContextStack implementation [logging-log4j2]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on issue #1507:
URL: https://github.com/apache/logging-log4j2/issues/1507#issuecomment-3149498317
@sschulze, what was/is your use case? Do you still need this functionality? If not, how did you address your use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Possibility to inject custom ThreadContextStack implementation [logging-log4j2]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on issue #1507:
URL: https://github.com/apache/logging-log4j2/issues/1507#issuecomment-3183408183
I'm closing this feature request due to lack of user interest. I've cloned the submitted implementation in #3810 to [feature/2.x/thread-context-stack-service-loader](/apache/logging-log4j2/tree/feature/2.x/thread-context-stack-service-loader) in case we might need to revise this decision in the future.
If you happen to be a user in need of this feature, please comment by explaining your use case in detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Possibility to inject custom ThreadContextStack implementation [logging-log4j2]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy closed issue #1507: Possibility to inject custom ThreadContextStack implementation
URL: https://github.com/apache/logging-log4j2/issues/1507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Possibility to inject custom ThreadContextStack implementation (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on issue #1507:
URL: https://github.com/apache/logging-log4j2/issues/1507#issuecomment-1587896033
@sschulze, I think your assessment is correct: `ThreadContext` always creates a `DefaultThreadContextStack` instance for its `ThreadContextStack`. Ideally `ThreadContextStack` should be provided by a `ThreadContextStackFactory` just like `ThreadContextMapFactory.createThreadContextMap()` does.
We would appreciate it if you can submit this as a PR. I strongly advise you to submit your design draft for review before dealing with the complete implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org