You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "OrezzerO (via GitHub)" <gi...@apache.org> on 2023/03/13 03:28:22 UTC
[GitHub] [dubbo] OrezzerO opened a new issue, #11796: ApplicationDeployer and ModuleDeployer interfaces have some duplicated methods comparing with Deployer . Can we delete it?
OrezzerO opened a new issue, #11796:
URL: https://github.com/apache/dubbo/issues/11796
ApplicationDeployer and ModuleDeployer interfaces have some duplicated methods comparing with Deployer . Can we delete it?
```java
/**
* Initialize the component
*/
void initialize() throws IllegalStateException;
/**
* Starts the component.
* @return
*/
Future start() throws IllegalStateException;
/**
* Stops the component.
*/
void stop() throws IllegalStateException;
```
These three methods both exists in `ApplicationDeployer`,`ModuleDeployer` and `Deployer` . Can we delete them from `ApplicationDeployer` and `ModuleDeployer` ?
BTW , some methods in `ApplicationDeployer` and `ModuleDeployer` are duplicated. Can we pull them up to `Deployer` ?
If there is no other issue, I will commit a pr to fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] imSanko commented on issue #11796: ApplicationDeployer and ModuleDeployer interfaces have some duplicated methods comparing with Deployer . Can we delete it?
Posted by "imSanko (via GitHub)" <gi...@apache.org>.
imSanko commented on issue #11796:
URL: https://github.com/apache/dubbo/issues/11796#issuecomment-1465502779
I've created a new pull request you can check it up !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] OrezzerO commented on issue #11796: ApplicationDeployer and ModuleDeployer interfaces have some duplicated methods comparing with Deployer . Can we delete it?
Posted by "OrezzerO (via GitHub)" <gi...@apache.org>.
OrezzerO commented on issue #11796:
URL: https://github.com/apache/dubbo/issues/11796#issuecomment-1465574738
I am talking about [ApplicationDeployer](https://github.com/apache/dubbo/blob/3.2/dubbo-common/src/main/java/org/apache/dubbo/common/deploy/ApplicationDeployer.java#L33) and [Deployer](https://github.com/apache/dubbo/blob/3.2/dubbo-common/src/main/java/org/apache/dubbo/common/deploy/Deployer.java#L28). It is the code of dubbo. There is no 'my software system'. @imSanko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #11796: ApplicationDeployer and ModuleDeployer interfaces have some duplicated methods comparing with Deployer . Can we delete it?
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #11796:
URL: https://github.com/apache/dubbo/issues/11796#issuecomment-1466061363
> BTW , some methods in ApplicationDeployer and ModuleDeployer are duplicated. Can we pull them up to Deployer ?
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] imSanko commented on issue #11796: ApplicationDeployer and ModuleDeployer interfaces have some duplicated methods comparing with Deployer . Can we delete it?
Posted by "imSanko (via GitHub)" <gi...@apache.org>.
imSanko commented on issue #11796:
URL: https://github.com/apache/dubbo/issues/11796#issuecomment-1465503135
Whether or not to delete the duplicated methods in the ApplicationDeployer and ModuleDeployer interfaces compared to the Deployer interface would depend on the specific design and requirements of your software system.
If the ApplicationDeployer and ModuleDeployer interfaces are intended to extend the Deployer interface and add additional functionality, then the duplicated methods may be necessary in order to ensure that each interface has a consistent set of methods that implementers must provide.
On the other hand, if the duplicated methods are not necessary for the functionality of the ApplicationDeployer and ModuleDeployer interfaces, then they could potentially be removed to simplify the interfaces and reduce code duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org