You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zhengchenyu (via GitHub)" <gi...@apache.org> on 2024/09/11 07:27:05 UTC
[PR] [#1606] feat(tez): Add retry mechanism for NO_BUFFER when reading dat… [incubator-uniffle]
zhengchenyu opened a new pull request, #2110:
URL: https://github.com/apache/incubator-uniffle/pull/2110
### What changes were proposed in this pull request?
Add retry mechanism tez. #1606 add retry mechanism, but forgot to add for tez.
### Why are the changes needed?
Fix: #1606
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1606] feat(tez): Add retry mechanism for NO_BUFFER when reading data(memory/local/index) [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2110:
URL: https://github.com/apache/incubator-uniffle/pull/2110#issuecomment-2345166453
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2110?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 52.32%. Comparing base [(`d170004`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/d170004a32418a32536aa792b198dfd714b5ea8c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`610333d`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/610333da30bfc30118da2d39dd2f5cdbf9a37483?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2110 +/- ##
============================================
+ Coverage 51.72% 52.32% +0.60%
+ Complexity 3275 2723 -552
============================================
Files 524 443 -81
Lines 29833 20639 -9194
Branches 2556 1892 -664
============================================
- Hits 15431 10800 -4631
+ Misses 13400 9152 -4248
+ Partials 1002 687 -315
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/2110?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1606] feat(tez): Add retry mechanism for NO_BUFFER when reading data(memory/local/index) [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2110:
URL: https://github.com/apache/incubator-uniffle/pull/2110#issuecomment-2342914725
## Test Results
2 882 files ±0 2 882 suites ±0 5h 57m 15s :stopwatch: +33s
1 019 tests ±0 1 018 :white_check_mark: ±0 1 :zzz: ±0 0 :x: ±0
12 868 runs ±0 12 853 :white_check_mark: ±0 15 :zzz: ±0 0 :x: ±0
Results for commit 238296aa. ± Comparison against base commit d170004a.
[test-results]:data:application/gzip;base64,H4sIABpM4WYC/03MTQ6DIBCG4asY1l3AIDL0Ms0ImpD60yCsmt69YJW6/J6ZvG82+mnY2L0BRLg1bEs+XrdLgaJflyKilSpTvsfyIbgw53xsydqf4d+e/lWswkh+ysArDCGs4ZCQlr0K2OExaxVQyWpHVZ1wqe77GrXrPPuYBwOJYDoiwXtQTqvOKCl175zUmqwhTmiMa4F9viTgL9wUAQAA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1606] feat(tez): Add retry mechanism for NO_BUFFER when reading data(memory/local/index) [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #2110:
URL: https://github.com/apache/incubator-uniffle/pull/2110#issuecomment-2345107233
Could you fix the style issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1606] feat(tez): Add retry mechanism for NO_BUFFER when reading data(memory/local/index) [incubator-uniffle]
Posted by "zhengchenyu (via GitHub)" <gi...@apache.org>.
zhengchenyu commented on PR #2110:
URL: https://github.com/apache/incubator-uniffle/pull/2110#issuecomment-2345158687
> Could you fix the style issue?
OK. And I modified some comments to meet the 2000 line limit for a single file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1606] feat(tez): Add retry mechanism for NO_BUFFER when reading data(memory/local/index) [incubator-uniffle]
Posted by "zhengchenyu (via GitHub)" <gi...@apache.org>.
zhengchenyu merged PR #2110:
URL: https://github.com/apache/incubator-uniffle/pull/2110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org