You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/12/10 01:26:00 UTC
[jira] [Commented] (TUBEMQ-446) Small bugs fix that do not affect
the main logics
[ https://issues.apache.org/jira/browse/TUBEMQ-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246943#comment-17246943 ]
ASF subversion and git services commented on TUBEMQ-446:
--------------------------------------------------------
Commit 66a9491b81ba9f0fe33acaca93359d596138a637 in incubator-tubemq's branch refs/heads/master from gosonzhang
[ https://gitbox.apache.org/repos/asf?p=incubator-tubemq.git;h=66a9491 ]
[TUBEMQ-446]Small bugs fix that do not affect the main logics (#346)
Co-authored-by: gosonzhang <go...@tencent.com>
> Small bugs fix that do not affect the main logics
> -------------------------------------------------
>
> Key: TUBEMQ-446
> URL: https://issues.apache.org/jira/browse/TUBEMQ-446
> Project: Apache TubeMQ
> Issue Type: Bug
> Reporter: Guocheng Zhang
> Assignee: Guocheng Zhang
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2020-12-09-18-53-02-498.png, image-2020-12-09-18-53-55-711.png, image-2020-12-09-20-04-14-698.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Found some small bugs
> 1. AddressUtils.getIPV4LocalAddress() should first check whether localIPAddress has been set, and use it directly under the premise that it has been set to reduce unnecessary get operations, locate: [https://github.com/apache/incubator-tubemq/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/AddressUtils.java#L146]
> !image-2020-12-09-18-53-02-498.png!
> 2. The fetchCount parameter in MessageConsumerExample may be negative, so the executorService object should not use fetchCount as the initial value, locate:[https://github.com/apache/incubator-tubemq/blob/master/tubemq-example/src/main/java/org/apache/tubemq/example/MessageConsumerExample.java#L99]
> !image-2020-12-09-18-53-55-711.png!
>
> 3. Remove the useless parameter WITHOUTDELAY:
> !image-2020-12-09-20-04-14-698.png!
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)