You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/17 06:34:55 UTC
[GitHub] [spark] MaxGekk opened a new pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
MaxGekk opened a new pull request #35885:
URL: https://github.com/apache/spark/pull/35885
### What changes were proposed in this pull request?
Revert the commit https://github.com/apache/spark/commit/e21cb62d02c85a66771822cdd49c49dbb3e44502 from `branch-3.3`.
### Why are the changes needed?
See discussion in the PR https://github.com/apache/spark/pull/35690.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By existing test suites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang removed a comment on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
gengliangwang removed a comment on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070512799
Thanks, merging to 3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070512799
Thanks, merging to 3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070629815
Merging to branch-3.3. Thank you, @gengliangwang @dongjoon-hyun and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070511531
We agreed on reverting already, @gengliangwang . :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070601490
Will make a fix soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070595186
It's passed at https://github.com/MaxGekk/spark/runs/5581819136?check_suite_focus=true so we can merge it anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070514715
@gengliangwang FYI, GAs haven't been triggered yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #35885:
URL: https://github.com/apache/spark/pull/35885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070452977
cc @dtenedor and @gengliangwang , too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070374327
@HyukjinKwon This is the PR created from scratch, but still GAs are not triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070515763
@dongjoon-hyun Yes
@MaxGekk yes I found it and deleted my comment :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35885: [SPARK-38566][SQL][3.3] Revert the parser changes for DEFAULT column support
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35885:
URL: https://github.com/apache/spark/pull/35885#issuecomment-1070494214
Actually having this in 3.3 can return a better error message if users are running queries with column default.
I am fine with either way, keep it or revert it. It's up to @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org