[GitHub] [carbondata] VenuReddy2103 commented on issue #3717: [HOTFIX]Old store read compatibility issue for Index handler column

[GitBox <gi...@apache.org>]

VenuReddy2103 commented on issue #3717: [HOTFIX]Old store read compatibility issue for Index handler column
URL: https://github.com/apache/carbondata/pull/3717#issuecomment-615913560
 
 
   > Isn't indexColumn property in columnSchema is optional, why need to add this check, or this check is in wrong place (should have check when this property is being used)
   
   Yes, It is optional. But, Table created in older version do not have indexColumn property in columnSchema.(schema.thrift). We had considered columnSchema.schemaOrdinal being -1 as index column instead of defining a new property. 
           But in  the later version, we have defined indexColumn property in columnSchema with default value as false. Due to this, when Old store is read, index handler column which is hidden to user is also treated as normal schema column(since indexColumn property default value is false) and user can perform operations like alter table on the index column and create inconsistency.
           Thats why, when we read the the schema, we update the indexColumn field in columnSchema to true if it is index column.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services