[GitHub] [arrow] sgilmore10 commented on a diff in pull request #35551: GH-35550: [MATLAB] Add public `toMATLAB` method to `arrow.array.Array` for converting to MATLAB types

["sgilmore10 (via GitHub)" <gi...@apache.org>]

sgilmore10 commented on code in PR #35551:
URL: https://github.com/apache/arrow/pull/35551#discussion_r1195320150


##########
matlab/src/cpp/arrow/matlab/array/proxy/array.cc:
##########
@@ -23,7 +23,7 @@ namespace arrow::matlab::array::proxy {
 
         // Register Proxy methods.
         REGISTER_METHOD(Array, ToString);
-        REGISTER_METHOD(Array, ToMatlab);
+        REGISTER_METHOD(Array, toMATLAB);

Review Comment:
   Hi @kou, That's a mistake on our part. `ToString` should be `toString`. Typically, we use lower camel case for MATLAB method names. Thanks for catching this!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org