[GitHub] [arrow] benibus commented on pull request #35798: GH-35579: [C++] Support non-named FieldRefs in Parquet scanner

["benibus (via GitHub)" <gi...@apache.org>]

benibus commented on PR #35798:
URL: https://github.com/apache/arrow/pull/35798#issuecomment-1568782245

   > What would happen if manifest not matches input in nested schema? Would extra checking is required here?
   Assume we have schema evolution in some of the dataset file, how to handle these file with mismatched Field?
   
   We shouldn't need any additional checks there, I don't think. The routine for resolving discrepancies between the dataset schema and file manifest (`ResolveOneFieldRef`) is unchanged - and the logic is still in terms of field names exclusively. All this PR really does is convert indexed refs into named refs (using the dataset schema) before those checks occur.
   
   That case should probably be reflected in the tests though... (anecdotally, it _did_ work in my ad hoc testing)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org