You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (Jira)" <ji...@apache.org> on 2023/06/13 18:32:00 UTC

[jira] [Comment Edited] (CASSANDRA-17992) Upgrade Netty on 5.0

    [ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732205#comment-17732205 ] 

Brandon Williams edited comment on CASSANDRA-17992 at 6/13/23 6:31 PM:
-----------------------------------------------------------------------

It's been a while and we have j17 baked into circle now, so I did a run to check the current status:

||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17992-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1060/workflows/fd02066d-4155-429e-87f4-20d3915e1634], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1060/workflows/e3dbaa54-108e-412a-9d06-b0ff3167c849]|

My branch has netty and tcnative upgraded to the latest, and bouncycastle is added. Here's what I see that needs to be fixed for netty:

* J11:
**  the log issue mentioned above causes test failures both by appearing unexpectedly, and also I think by taking the place of expected erorrs in some cases
** a strange ttl_test dtest failure

* j17:
** all the j11 problems
** InternodeEncryptionOptionsTest is failing again, but differently after adding bouncycastle

I'll see if I can figure out what's going on with the ttl_test failure.


was (Author: brandon.williams):
It's been a while and we have j17 baked into circle now, so I did a run to check the current status:

||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17992-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1060/workflows/fd02066d-4155-429e-87f4-20d3915e1634], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1060/workflows/e3dbaa54-108e-412a-9d06-b0ff3167c849]|

My branch has netty and tcnative upgraded to the latest, and bouncycastle is added. Here's what I see that needs to be fixed for netty:

*J11:
**  the log issue mentioned above causes test failures both by appearing unexpectedly, and also I think by taking the place of expected erorrs in some cases
** a strange ttl_test dtest failure

* j17:
** all the j11 problems
** InternodeEncryptionOptionsTest is failing again, but differently after adding bouncycastle

I'll see if I can figure out what's going on with the ttl_test failure.

> Upgrade Netty on 5.0
> --------------------
>
>                 Key: CASSANDRA-17992
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17992
>             Project: Cassandra
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Low
>             Fix For: 5.x
>
>
> I haven't been able to identify from the Netty docs which was the lowest version where JDK17 was added but we are about 40 versions behind in netty 4 so I suspect we better update. 
> -We need to consider there was an issue with class cast exceptions when building with JDK17 with newer versions of netty (the newest available in March 2022). For the record, we didn't see those when running CI on JDK8 and JDK11. We also need to carefully revise the changes between the netty versions. -->- CASSANDRA-18180
> Upgrading will cover also a fix in netty that was discussed in [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF Slack thread. 
> CC [~benedict] , [~aleksey] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org