You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/01/25 06:59:25 UTC

[GitHub] [hop] gvdutra opened a new pull request #1289: [HOP-1888] Rename package org.apache.hop.pipeline.transform.errorhand…

gvdutra opened a new pull request #1289:
URL: https://github.com/apache/hop/pull/1289


   …ling
   
   Following this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/HOP) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[HOP-XXX] - Fixes bug in SessionManager`,
          where you replace `HOP-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. 
    
   Trivial changes like typos do not require a JIRA issue (javadoc, comments...). 
   In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
    
   If this is your first contribution, you have to read the [Contribution Guidelines](https://hop.apache.org/community/contributing/)
   
   If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) 
   if you are unsure please ask on the developers list.
   
   To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] gvdutra commented on pull request #1289: [HOP-1888] Rename package org.apache.hop.pipeline.transform.errorhand…

Posted by GitBox <gi...@apache.org>.
gvdutra commented on pull request #1289:
URL: https://github.com/apache/hop/pull/1289#issuecomment-1020894483


   Hi, some sort of timeout? Could you please run it again?
   
   ` Error:  Failed to execute goal on project hop-transform-xml: Could not resolve dependencies for project org.apache.hop:hop-transform-xml:jar:1.2.0-SNAPSHOT: Failed to collect dependencies at org.apache.poi:poi:jar:5.2.0: Failed to read artifact descriptor for org.apache.poi:poi:jar:5.2.0: Could not transfer artifact org.apache.poi:poi:pom:5.2.0 from/to central (https://repo1.maven.org/maven2/): transfer failed for https://repo1.maven.org/maven2/org/apache/poi/poi/5.2.0/poi-5.2.0.pom: Connection timed out (Read failed) -> [Help 1]`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] gvdutra commented on pull request #1289: [HOP-1888] Rename package org.apache.hop.pipeline.transform.errorhand…

Posted by GitBox <gi...@apache.org>.
gvdutra commented on pull request #1289:
URL: https://github.com/apache/hop/pull/1289#issuecomment-1020894483


   Hi, some sort of timeout? Could you please run it again?
   
   ` Error:  Failed to execute goal on project hop-transform-xml: Could not resolve dependencies for project org.apache.hop:hop-transform-xml:jar:1.2.0-SNAPSHOT: Failed to collect dependencies at org.apache.poi:poi:jar:5.2.0: Failed to read artifact descriptor for org.apache.poi:poi:jar:5.2.0: Could not transfer artifact org.apache.poi:poi:pom:5.2.0 from/to central (https://repo1.maven.org/maven2/): transfer failed for https://repo1.maven.org/maven2/org/apache/poi/poi/5.2.0/poi-5.2.0.pom: Connection timed out (Read failed) -> [Help 1]`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva commented on pull request #1289: [HOP-1888] Rename package org.apache.hop.pipeline.transform.errorhand…

Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1289:
URL: https://github.com/apache/hop/pull/1289#issuecomment-1020908234


   As this PR is breaking API and possibly external transforms I am going to move it to the 2.0 branch and document the change for external developers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva commented on pull request #1289: [HOP-1888] Rename package org.apache.hop.pipeline.transform.errorhand…

Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1289:
URL: https://github.com/apache/hop/pull/1289#issuecomment-1020896438


   It's been a while since we had a timeout, but it does happen. Restarted the GHA.
   And thanks for the improvement!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva commented on pull request #1289: [HOP-1888] Rename package org.apache.hop.pipeline.transform.errorhand…

Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1289:
URL: https://github.com/apache/hop/pull/1289#issuecomment-1020896438






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva merged pull request #1289: [HOP-1888] Rename package org.apache.hop.pipeline.transform.errorhand…

Posted by GitBox <gi...@apache.org>.
hansva merged pull request #1289:
URL: https://github.com/apache/hop/pull/1289


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org