You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/02/07 13:19:49 UTC

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16754: [BEAM-13838][Playground] Add logs in case of empty graph for CD step

AydarZaynutdinov commented on a change in pull request #16754:
URL: https://github.com/apache/beam/pull/16754#discussion_r800646520



##########
File path: playground/infrastructure/helper.py
##########
@@ -341,13 +342,13 @@ def _validate(tag: dict, supported_categories: List[str]) -> bool:
   # check that context line's value is integer
   context_line = tag.get(TagFields.context_line)
   if not isinstance(context_line, int):
-      logging.error(
-          "tag's field context_line is incorrect: %s \n"
-          "context_line variable should be integer format, "
-          "but tag contains: %s",
-          tag,
-          context_line)
-      valid = False
+    logging.error(
+        "tag's field context_line is incorrect: %s \n"
+        "context_line variable should be integer format, "

Review comment:
       `context_line` is the name of the field. Maybe better to use lower-case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org