You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@toree.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/08/11 02:15:33 UTC
[GitHub] [incubator-toree] pan3793 opened a new pull request, #216: Revert "[TOREE-543] Fix and enable JVMReprSpec"
pan3793 opened a new pull request, #216:
URL: https://github.com/apache/incubator-toree/pull/216
Reverts apache/incubator-toree#209
It fixes the UT, but unfortunately, breaks the real workload ...
<img width="1020" alt="image" src="https://github.com/apache/incubator-toree/assets/26535726/87b75d7b-7b16-4520-b709-3e1c89583752">
We need to explore another way to adjust the test case, or change the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-toree] pan3793 commented on pull request #216: Revert "[TOREE-543] Fix and enable JVMReprSpec"
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #216:
URL: https://github.com/apache/incubator-toree/pull/216#issuecomment-1674150679
@lresende I'm really sorry about that, will do such testing for other PRs in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-toree] pan3793 commented on pull request #216: Revert "[TOREE-543] Fix and enable JVMReprSpec"
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #216:
URL: https://github.com/apache/incubator-toree/pull/216#issuecomment-1687354883
@lresende thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-toree] lresende merged pull request #216: Revert "[TOREE-543] Fix and enable JVMReprSpec"
Posted by "lresende (via GitHub)" <gi...@apache.org>.
lresende merged PR #216:
URL: https://github.com/apache/incubator-toree/pull/216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org