[GitHub] [echarts] pissang commented on a diff in pull request #16026: Fix(markline): markLine shouldn't be filtered if one point is out side of the grid

[GitBox <gi...@apache.org>]

pissang commented on code in PR #16026:
URL: https://github.com/apache/echarts/pull/16026#discussion_r846920739


##########
src/component/marker/MarkLineView.ts:
##########
@@ -192,7 +193,7 @@ function markLineFilter(
         }
     }
     return markerHelper.dataFilter(coordSys, item[0])
-        && markerHelper.dataFilter(coordSys, item[1]);
+        || markerHelper.dataFilter(coordSys, item[1]);

Review Comment:
   Sorry for the late review.
   
   I'm not sure but seems this check is more precise than the previous 
   https://github.com/apache/echarts/blob/b002ab2c9bff7c226fcc7d67a7f2b9b9ff91c3ad/src/component/marker/MarkLineView.ts#L191
   Can we remove this code and only use the new one instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org