[hudi] branch master updated: [HUDI-5063] Enabling run time stats to be serialized with commit metadata (#7006)

[yi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

yihua pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new 9c3b57cc2e [HUDI-5063] Enabling run time stats to be serialized with commit metadata (#7006)
9c3b57cc2e is described below

commit 9c3b57cc2e46ded3221c32b6f20810c263d637f2
Author: Sivabalan Narayanan <n....@gmail.com>
AuthorDate: Fri Oct 21 18:53:32 2022 -0700

    [HUDI-5063] Enabling run time stats to be serialized with commit metadata (#7006)
---
 .../src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java  | 4 ----
 .../java/org/apache/hudi/common/model/TestHoodieCommitMetadata.java  | 5 +++--
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java b/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java
index 91637102f0..6c1efc1561 100644
--- a/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java
+++ b/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java
@@ -18,8 +18,6 @@
 
 package org.apache.hudi.common.model;
 
-import com.fasterxml.jackson.annotation.JsonIgnore;
-import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import org.apache.hadoop.fs.Path;
 import org.apache.hudi.common.util.JsonUtils;
 
@@ -31,7 +29,6 @@ import java.util.Map;
 /**
  * Statistics about a single Hoodie write operation.
  */
-@JsonIgnoreProperties(ignoreUnknown = true)
 public class HoodieWriteStat implements Serializable {
 
   public static final String NULL_COMMIT = "null";
@@ -163,7 +160,6 @@ public class HoodieWriteStat implements Serializable {
   private Long maxEventTime;
 
   @Nullable
-  @JsonIgnore
   private RuntimeStats runtimeStats;
 
   public HoodieWriteStat() {
diff --git a/hudi-common/src/test/java/org/apache/hudi/common/model/TestHoodieCommitMetadata.java b/hudi-common/src/test/java/org/apache/hudi/common/model/TestHoodieCommitMetadata.java
index b0b59f8cbc..e8c159540a 100644
--- a/hudi-common/src/test/java/org/apache/hudi/common/model/TestHoodieCommitMetadata.java
+++ b/hudi-common/src/test/java/org/apache/hudi/common/model/TestHoodieCommitMetadata.java
@@ -77,8 +77,9 @@ public class TestHoodieCommitMetadata {
     String serializedCommitMetadata = commitMetadata.toJsonString();
     HoodieCommitMetadata metadata =
         HoodieCommitMetadata.fromJsonString(serializedCommitMetadata, HoodieCommitMetadata.class);
-    // Make sure timing metrics are not written to instant file
-    assertEquals(0, (long) metadata.getTotalScanTime());
+    assertTrue(commitMetadata.getTotalCreateTime() > 0);
+    assertTrue(commitMetadata.getTotalUpsertTime() > 0);
+    assertTrue(commitMetadata.getTotalScanTime() > 0);
     assertTrue(metadata.getTotalLogFilesCompacted() > 0);
   }