You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/02/04 18:12:32 UTC

[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1539: build: Remove the annoy warning from distclean

xiaoxiang781216 opened a new pull request, #1539:
URL: https://github.com/apache/nuttx-apps/pull/1539

   ## Summary
   
   and nuttx/tools/testbuild.sh already do the same check.
   
   ## Impact
   
   Minor
   
   ## Testing
   
   CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1539: build: Remove the annoy warning from distclean

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #1539:
URL: https://github.com/apache/nuttx-apps/pull/1539#discussion_r1096573698


##########
Makefile:
##########
@@ -205,20 +205,6 @@ clean: $(foreach SDIR, $(CLEANDIRS), $(SDIR)_clean)
 	$(call CLEAN)
 
 distclean: $(foreach SDIR, $(CLEANDIRS), $(SDIR)_distclean)
-ifeq ($(CONFIG_WINDOWS_NATIVE),y)

Review Comment:
   But does testbuild.sh suitable for windows native build?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1539: build: Remove the annoy warning from distclean

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1539:
URL: https://github.com/apache/nuttx-apps/pull/1539#discussion_r1096575894


##########
Makefile:
##########
@@ -205,20 +205,6 @@ clean: $(foreach SDIR, $(CLEANDIRS), $(SDIR)_clean)
 	$(call CLEAN)
 
 distclean: $(foreach SDIR, $(CLEANDIRS), $(SDIR)_distclean)
-ifeq ($(CONFIG_WINDOWS_NATIVE),y)

Review Comment:
   Linux/macOS CI could catch all path since they cover all defined config except a few ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] GUIDINGLI merged pull request #1539: build: Remove the annoy warning from distclean

Posted by "GUIDINGLI (via GitHub)" <gi...@apache.org>.
GUIDINGLI merged PR #1539:
URL: https://github.com/apache/nuttx-apps/pull/1539


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org